Fall back to shortcut A2HS when Phonesky is out of date or unavailable.

chrome/browser/android/webapk/webapk_installer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapk/webapk_installer.h"
 
 #include "base/android/build_info.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/android/path_utils.h"
@@ skipping 409 matching lines @@
 
   GURL signed_download_url(response->signed_download_url());
   if (!signed_download_url.is_valid() || response->package_name().empty()) {
     OnFailure();
     return;
   }
 
   if (CanUseGooglePlayInstallService()) {
     int version = 1;
     base::StringToInt(response->version(), &version);
-    if (!InstallOrUpdateWebApkFromGooglePlay(
-        response->package_name(), version, response->token())) {
-      OnFailure();
-    }
+    InstallOrUpdateWebApkFromGooglePlay(
+        response->package_name(), version, response->token());

[pkotwicz, 2017/02/03 18:56:32]

Why this change? If we are ignoring the return value of
InstallOrUpdateWebApkFromGooglePlay(), InstallOrUpdateWebApkFromGooglePlay()
should not have a return value.

[Xi Han, 2017/02/03 22:16:21]

This is because ChromeWebApkHost::CanUseGooglePlayInstallApi(callback) always
wait for the callback to be called, even for the failure case. However, that API
eventually share the same code with InstallOrUpdateWebApkFromGooglePlay(). I
will introduce a follow up CL to remove all the return values of the
InstallOrUpdateWebApkFromGooglePlay().

[pkotwicz, 2017/02/03 23:05:05]

Please file the bug too :)

     return;
   }
 
   OnGotWebApkDownloadUrl(signed_download_url, response->package_name());
 }
 
 void WebApkInstaller::DownloadAppIconAndComputeMurmur2Hash() {
   // Safeguard. WebApkIconHasher crashes if asked to fetch an invalid URL.
   if (!shortcut_info_.best_icon_url.is_valid()) {
     OnFailure();
@@ skipping 176 matching lines @@
 
 void WebApkInstaller::OnSuccess() {
   finish_callback_.Run(true, webapk_package_);
   delete this;
 }
 
 void WebApkInstaller::OnFailure() {
   finish_callback_.Run(false, webapk_package_);
   delete this;
 }