Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chrome/browser/android/webapk/webapk_installer.cc

Issue 2675803004: Fall back to shortcut A2HS when Phonesky is out of date or unavailable. (Closed)
Patch Set: dominickn@'s comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_installer.cc
diff --git a/chrome/browser/android/webapk/webapk_installer.cc b/chrome/browser/android/webapk/webapk_installer.cc
index 161a3881865f2dd5aa258762a891f35d4ba10ac9..4d164ecb21537a828cd21fb99cff0bd1f656973a 100644
--- a/chrome/browser/android/webapk/webapk_installer.cc
+++ b/chrome/browser/android/webapk/webapk_installer.cc
@@ -427,10 +427,10 @@ void WebApkInstaller::OnURLFetchComplete(const net::URLFetcher* source) {
if (CanUseGooglePlayInstallService()) {
int version = 1;
base::StringToInt(response->version(), &version);
- if (!InstallOrUpdateWebApkFromGooglePlay(
- response->package_name(), version, response->token())) {
- OnFailure();
- }
+ // TODO(hanxi): crbug.com/688759. Removes the return value of
+ // |InstallOrUpdateWebApkFromGooglePlay()| which is executed asynchronously.
pkotwicz 2017/02/05 02:13:55 Nits: "Removes" -> "Remove" "|InstallOrUpdateWebAp
Xi Han 2017/02/06 18:03:44 How about "Remove the return value of InstallOrUpd
pkotwicz 2017/02/06 23:12:12 One small nit: "is either" -> "has either" Otherwi
Xi Han 2017/02/07 02:52:10 Done.
+ InstallOrUpdateWebApkFromGooglePlay(
+ response->package_name(), version, response->token());
return;
}

Powered by Google App Engine
This is Rietveld 408576698