Chromium Code Reviews| Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java |
| diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java |
| index a32ff99e8f255816a1676f2fa5ecd27c53973032..4b188461987ac0f3f6c1007e04346aa23ac3a3ae 100644 |
| --- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java |
| +++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java |
| @@ -20,8 +20,6 @@ import org.chromium.base.annotations.CalledByNative; |
| import org.chromium.chrome.browser.ChromeApplication; |
| import org.chromium.chrome.browser.ShortcutHelper; |
| import org.chromium.chrome.browser.banners.InstallerDelegate; |
| -import org.chromium.chrome.browser.externalauth.ExternalAuthUtils; |
| -import org.chromium.chrome.browser.externalauth.UserRecoverableErrorHandler; |
| import org.chromium.chrome.browser.util.IntentUtils; |
| import java.io.File; |
| @@ -66,9 +64,7 @@ public class WebApkInstaller { |
| @CalledByNative |
| private boolean canUseGooglePlayInstallService() { |
| return mGooglePlayWebApkInstallDelegate != null |
|
pkotwicz
2017/02/05 02:13:54
Can the null check be removed?
Xi Han
2017/02/06 18:03:43
Done.
|
| - && ExternalAuthUtils.getInstance().canUseGooglePlayServices( |
| - ContextUtils.getApplicationContext(), |
| - new UserRecoverableErrorHandler.Silent()); |
| + && ChromeWebApkHost.canUseGooglePlayToInstallWebApk(); |
| } |
| @CalledByNative |
| @@ -118,20 +114,27 @@ public class WebApkInstaller { |
| @CalledByNative |
| private boolean installWebApkFromGooglePlayAsync(String packageName, int version, String title, |
| String token, String url) { |
| - if (mGooglePlayWebApkInstallDelegate == null) return false; |
| + if (mGooglePlayWebApkInstallDelegate == null) { |
| + notify(false); |
| + return false; |
| + } |
| Callback<Boolean> callback = new Callback<Boolean>() { |
| @Override |
| public void onResult(Boolean success) { |
| - if (mNativePointer != 0) { |
| - nativeOnInstallFinished(mNativePointer, success); |
| - } |
| + WebApkInstaller.this.notify(success); |
| } |
| }; |
| return mGooglePlayWebApkInstallDelegate.installAsync(packageName, version, title, token, |
| url, callback); |
| } |
| + private void notify(boolean success) { |
| + if (mNativePointer != 0) { |
| + nativeOnInstallFinished(mNativePointer, success); |
| + } |
| + } |
| + |
| /** |
| * Updates a WebAPK. |
| * @param filePath File to update. |