Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1383)

Unified Diff: chrome/browser/android/webapk/chrome_webapk_host.cc

Issue 2675803004: Fall back to shortcut A2HS when Phonesky is out of date or unavailable. (Closed)
Patch Set: dominickn@'s comments. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/chrome_webapk_host.cc
diff --git a/chrome/browser/android/webapk/chrome_webapk_host.cc b/chrome/browser/android/webapk/chrome_webapk_host.cc
index 1ebfe489246fc3076d391f0c714144da27011ca7..ab33479d198b3d3e33b44f1d23b6f9f196288b0b 100644
--- a/chrome/browser/android/webapk/chrome_webapk_host.cc
+++ b/chrome/browser/android/webapk/chrome_webapk_host.cc
@@ -21,9 +21,9 @@ bool ChromeWebApkHost::Register(JNIEnv* env) {
}
// static
-bool ChromeWebApkHost::AreWebApkEnabled() {
+bool ChromeWebApkHost::CanInstallWebApk() {
JNIEnv* env = base::android::AttachCurrentThread();
- return Java_ChromeWebApkHost_areWebApkEnabled(env);
+ return Java_ChromeWebApkHost_isWebApkInstallFlowAvailable(env);
}
// static
@@ -33,3 +33,12 @@ jboolean CanUseGooglePlayToInstallWebApk(
return variations::GetVariationParamValueByFeature(
chrome::android::kImprovedA2HS, kPlayInstall) == "true";
}
+
+// static
+jboolean CanInstallFromUnknownSources(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jclass>& clazz) {
+ return base::FeatureList::GetInstance()->IsFeatureOverriddenFromCommandLine(
+ chrome::android::kImprovedA2HS.name,
+ base::FeatureList::OVERRIDE_ENABLE_FEATURE);
+}

Powered by Google App Engine
This is Rietveld 408576698