chrome/browser/android/banners/app_banner_manager_android.cc - Issue 2675803004: Fall back to shortcut A2HS when Phonesky is out of date or unavailable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 2675803004: Fall back to shortcut A2HS when Phonesky is out of date or unavailable. (Closed)

Patch Set: dominickn@'s comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/banners/app_banner_manager_android.cc

diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc

index e5f96225074296d8df1ec0f325b08f56ee755f47..182f6d7118b79492258b99aa50f718fc75c3f737 100644

--- a/chrome/browser/android/banners/app_banner_manager_android.cc

+++ b/chrome/browser/android/banners/app_banner_manager_android.cc

@@ -172,7 +172,7 @@ void AppBannerManagerAndroid::PerformInstallableCheck() {

Stop();

}

- if (ChromeWebApkHost::AreWebApkEnabled()) {

+ if (ChromeWebApkHost::CanInstallWebApk()) {

if (!AreWebManifestUrlsWebApkCompatible(manifest_)) {

ReportStatus(web_contents(), URL_NOT_SUPPORTED_FOR_WEBAPK);

Stop();