Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 26758003: Retire concurrent recompilation delay for non-stress testing. (Closed)

Created:
7 years, 2 months ago by Yang
Modified:
7 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Retire concurrent recompilation delay for non-stress testing. Instead, we block concurrent recompilation until unblocked. This makes affected tests more predictable and run shorter. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17199

Patch Set 1 #

Patch Set 2 : rename and move files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -255 lines) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/optimizing-compiler-thread.h View 3 chunks +5 lines, -1 line 0 comments Download
M src/optimizing-compiler-thread.cc View 3 chunks +16 lines, -1 line 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +7 lines, -0 lines 0 comments Download
A + test/mjsunit/compiler/concurrent-invalidate-transition-map.js View 1 2 chunks +7 lines, -3 lines 0 comments Download
A + test/mjsunit/compiler/concurrent-proto-change.js View 1 2 chunks +7 lines, -5 lines 0 comments Download
A + test/mjsunit/compiler/manual-concurrent-recompile.js View 1 2 chunks +7 lines, -4 lines 0 comments Download
M test/mjsunit/compiler/parallel-proto-change.js View 1 1 chunk +0 lines, -54 lines 0 comments Download
A + test/mjsunit/concurrent-initial-prototype-change.js View 1 2 chunks +7 lines, -4 lines 0 comments Download
M test/mjsunit/manual-parallel-recompile.js View 1 1 chunk +0 lines, -64 lines 0 comments Download
M test/mjsunit/parallel-initial-prototype-change.js View 1 1 chunk +0 lines, -54 lines 0 comments Download
M test/mjsunit/parallel-invalidate-transition-map.js View 1 1 chunk +0 lines, -57 lines 0 comments Download
M test/mjsunit/regress/regress-embedded-cons-string.js View 2 chunks +6 lines, -4 lines 0 comments Download
M test/mjsunit/regress/regress-opt-after-debug-deopt.js View 2 chunks +7 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-prepare-break-while-recompile.js View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 2 months ago (2013-10-14 13:34:39 UTC) #1
Jakob Kummerow
LGTM. Thanks!
7 years, 2 months ago (2013-10-14 14:01:05 UTC) #2
Yang
7 years, 2 months ago (2013-10-14 14:15:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17199 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698