Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1595)

Unified Diff: test/mjsunit/compiler/manual-concurrent-recompile.js

Issue 26758003: Retire concurrent recompilation delay for non-stress testing. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: rename and move files Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/compiler/concurrent-proto-change.js ('k') | test/mjsunit/compiler/parallel-proto-change.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/compiler/manual-concurrent-recompile.js
diff --git a/test/mjsunit/manual-parallel-recompile.js b/test/mjsunit/compiler/manual-concurrent-recompile.js
similarity index 87%
rename from test/mjsunit/manual-parallel-recompile.js
rename to test/mjsunit/compiler/manual-concurrent-recompile.js
index 0a0e61d5248c37ca35534f3f84cb1efd09c3e597..b2b63988babf7c8a9af561d126dc65a592b73747 100644
--- a/test/mjsunit/manual-parallel-recompile.js
+++ b/test/mjsunit/compiler/manual-concurrent-recompile.js
@@ -26,7 +26,7 @@
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
// Flags: --allow-natives-syntax --expose-gc
-// Flags: --concurrent-recompilation --concurrent-recompilation-delay=50
+// Flags: --concurrent-recompilation --block-concurrent-recompilation
if (!%IsConcurrentRecompilationSupported()) {
print("Concurrent recompilation is disabled. Skipping this test.");
@@ -55,10 +55,13 @@ assertUnoptimized(g);
%OptimizeFunctionOnNextCall(f, "concurrent");
%OptimizeFunctionOnNextCall(g, "concurrent");
-f(g(2)); // Trigger optimization.
+f(g(2)); // Kick off recompilation.
-assertUnoptimized(f, "no sync"); // Not yet optimized while background thread
-assertUnoptimized(g, "no sync"); // is running.
+assertUnoptimized(f, "no sync"); // Not yet optimized since recompilation
+assertUnoptimized(g, "no sync"); // is still blocked.
+
+// Let concurrent recompilation proceed.
+%UnblockConcurrentRecompilation();
assertOptimized(f, "sync"); // Optimized once we sync with the
assertOptimized(g, "sync"); // background thread.
« no previous file with comments | « test/mjsunit/compiler/concurrent-proto-change.js ('k') | test/mjsunit/compiler/parallel-proto-change.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698