Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issue 2675793002: [turbofan] Properly ensure that deoptimization is enabled. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Properly ensure that deoptimization is enabled. We cannot optimize global proxy access unless deoptimization is enabled. BUG=chromium:687990 R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2675793002 Cr-Commit-Position: refs/heads/master@{#42928} Committed: https://chromium.googlesource.com/v8/v8/+/c21d1281d9a0c9db39441d798ff04d164d76259f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +7 lines, -5 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-687990.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-02 18:23:59 UTC) #1
Benedikt Meurer
Hey Jaro, Trivial fix. Please take a look. Thanks, Benedikt
3 years, 10 months ago (2017-02-02 18:24:23 UTC) #2
Jarin
lgtm
3 years, 10 months ago (2017-02-03 13:48:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675793002/1
3 years, 10 months ago (2017-02-03 13:48:40 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 14:06:12 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c21d1281d9a0c9db39441d798ff04d164d7...

Powered by Google App Engine
This is Rietveld 408576698