Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2675783003: Revert of [Android] Allow get/setsockopt SOL_SOCKET SO_SNDTIMEO. (Closed)

Created:
3 years, 10 months ago by Robert Sesek
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Allow get/setsockopt SOL_SOCKET SO_SNDTIMEO. (patchset #3 id:60001 of https://codereview.chromium.org/2653923005/ ) Reason for revert: Spike in crashes because getsockopt is overly-restricted. Original issue's description: > [Android] Allow get/setsockopt SOL_SOCKET SO_SNDTIMEO. > > BUG=682488 > R=jorgelo@chromium.org > > Review-Url: https://codereview.chromium.org/2653923005 > Cr-Commit-Position: refs/heads/master@{#447507} > Committed: https://chromium.googlesource.com/chromium/src/+/bd716dcb8575e046af147dd1b69f56090c77b4e4 TBR=jorgelo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=682488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -19 lines) Patch
M content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc View 2 chunks +7 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Robert Sesek
Created Revert of [Android] Allow get/setsockopt SOL_SOCKET SO_SNDTIMEO.
3 years, 10 months ago (2017-02-02 18:34:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675783003/1
3 years, 10 months ago (2017-02-02 18:35:06 UTC) #3
Jorge Lucangeli Obes
I thought the CL was allowing more stuff. Why does it cause more crashes?
3 years, 10 months ago (2017-02-02 18:35:26 UTC) #4
Robert Sesek
On 2017/02/02 18:35:26, Jorge Lucangeli Obes wrote: > I thought the CL was allowing more ...
3 years, 10 months ago (2017-02-02 18:36:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/111557)
3 years, 10 months ago (2017-02-02 20:46:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675783003/1
3 years, 10 months ago (2017-02-02 21:08:30 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 23:04:55 UTC) #11
Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

Powered by Google App Engine
This is Rietveld 408576698