|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by Robert Sesek Modified:
3 years, 10 months ago Reviewers:
Jorge Lucangeli Obes CC:
chromium-reviews, jam, darin-cc_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Android] Allow get/setsockopt SOL_SOCKET SO_SNDTIMEO.
BUG=682488
R=jorgelo@chromium.org
Review-Url: https://codereview.chromium.org/2653923005
Cr-Commit-Position: refs/heads/master@{#447507}
Committed: https://chromium.googlesource.com/chromium/src/+/bd716dcb8575e046af147dd1b69f56090c77b4e4
Patch Set 1 : '' #Patch Set 2 : mucking #Patch Set 3 : '' #Messages
Total messages: 21 (16 generated)
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by rsesek@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jorgelo@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485958667033040,
"parent_rev": "dfb10e743132bac81702c2a3685f4c7c782d368f", "commit_rev":
"bd716dcb8575e046af147dd1b69f56090c77b4e4"}
Message was sent while issue was closed.
Description was changed from ========== [Android] Allow get/setsockopt SOL_SOCKET SO_SNDTIMEO. BUG=682488 R=jorgelo@chromium.org ========== to ========== [Android] Allow get/setsockopt SOL_SOCKET SO_SNDTIMEO. BUG=682488 R=jorgelo@chromium.org Review-Url: https://codereview.chromium.org/2653923005 Cr-Commit-Position: refs/heads/master@{#447507} Committed: https://chromium.googlesource.com/chromium/src/+/bd716dcb8575e046af147dd1b69f... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/bd716dcb8575e046af147dd1b69f...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in https://codereview.chromium.org/2675783003/ by rsesek@chromium.org. The reason for reverting is: Spike in crashes because getsockopt is overly-restricted.. |
