Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2653923005: [Android] Allow get/setsockopt SOL_SOCKET SO_SNDTIMEO. (Closed)

Created:
3 years, 11 months ago by Robert Sesek
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Allow get/setsockopt SOL_SOCKET SO_SNDTIMEO. BUG=682488 R=jorgelo@chromium.org Review-Url: https://codereview.chromium.org/2653923005 Cr-Commit-Position: refs/heads/master@{#447507} Committed: https://chromium.googlesource.com/chromium/src/+/bd716dcb8575e046af147dd1b69f56090c77b4e4

Patch Set 1 : '' #

Patch Set 2 : mucking #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -7 lines) Patch
M content/common/sandbox_linux/android/sandbox_bpf_base_policy_android.cc View 1 2 2 chunks +19 lines, -7 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Robert Sesek
3 years, 10 months ago (2017-02-01 11:18:18 UTC) #14
Jorge Lucangeli Obes
lgtm
3 years, 10 months ago (2017-02-01 14:17:47 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2653923005/60001
3 years, 10 months ago (2017-02-01 14:18:01 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/bd716dcb8575e046af147dd1b69f56090c77b4e4
3 years, 10 months ago (2017-02-01 14:32:55 UTC) #20
Robert Sesek
3 years, 10 months ago (2017-02-02 18:34:14 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/2675783003/ by rsesek@chromium.org.

The reason for reverting is: Spike in crashes because getsockopt is
overly-restricted..

Powered by Google App Engine
This is Rietveld 408576698