Optimize CompositingRecorder::endCompositing to not need an SkPictureBuilder

Optimize CompositingRecorder::endCompositing to not need an SkPictureBuilder

CompositingRecorder::endCompositing has an optimization [1] to turn
patterns like [..., begin compositing, drawing, end compositing]
into [..., composited drawing] which takes advantage of an SkPicture
recording optimization. An SkPictureBuilder is not needed in this
case, as we can modify the underlying display list while creating the
new composited drawing. To do this, a DCHECK in DrawingRecorder that
the underlying list doesn't change has been suppressed with
DisableListModificationCheck.

The last user of DisableNullPaintPropertyChecks has been removed which
lets us delete code from PaintChunker.

[1] https://codereview.chromium.org/2186643002

BUG=628831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2675773003
Cr-Commit-Position: refs/heads/master@{#447903}
Committed: https://chromium.googlesource.com/chromium/src/+/424a2d302d2106dabd248ee96ab751bd54d38f1a

[pdr., 2017-02-02 20:05:59]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 20:06:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2017-02-02 21:52:58]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, danakj@chromium.org

[commit-bot: I haz the power, 2017-02-02 22:29:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 22:29:17]

Dry run: This issue passed the CQ dry run.

[pdr., 2017-02-02 23:51:07]

Description was changed from

==========
Optimize CompositingRecorder::endCompositing to not need an SkPictureBuilder

CompositingRecorder::endCompositing has an optimization [1] to turn
patterns like [..., begin compositing, drawing, end compositing]
into [..., composited drawing] which takes advantage of an SkPicture
recording optimization. An SkPictureBuilder is not needed in this
case, as we can modify the underlying display list while creating the
new composited drawing.

[1] https://codereview.chromium.org/2186643002

BUG=628831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Optimize CompositingRecorder::endCompositing to not need an SkPictureBuilder

CompositingRecorder::endCompositing has an optimization [1] to turn
patterns like [..., begin compositing, drawing, end compositing]
into [..., composited drawing] which takes advantage of an SkPicture
recording optimization. An SkPictureBuilder is not needed in this
case, as we can modify the underlying display list while creating the
new composited drawing. To do this, a DCHECK in DrawingRecorder that
the underlying list doesn't change has been removed.

The last user of DisableNullPaintPropertyChecks has been removed which
lets us delete code from PaintChunker.

[1] https://codereview.chromium.org/2186643002

BUG=628831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-02-02 23:52:07]

https://codereview.chromium.org/2675773003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
(left):

https://codereview.chromium.org/2675773003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp:78:
DCHECK(m_displayItemPosition ==
This DCHECK still seems generally useful. Pass an extra arg
to suppress it for CompositingRecorder?

[pdr., 2017-02-03 00:10:17]

Description was changed from

==========
Optimize CompositingRecorder::endCompositing to not need an SkPictureBuilder

CompositingRecorder::endCompositing has an optimization [1] to turn
patterns like [..., begin compositing, drawing, end compositing]
into [..., composited drawing] which takes advantage of an SkPicture
recording optimization. An SkPictureBuilder is not needed in this
case, as we can modify the underlying display list while creating the
new composited drawing. To do this, a DCHECK in DrawingRecorder that
the underlying list doesn't change has been removed.

The last user of DisableNullPaintPropertyChecks has been removed which
lets us delete code from PaintChunker.

[1] https://codereview.chromium.org/2186643002

BUG=628831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Optimize CompositingRecorder::endCompositing to not need an SkPictureBuilder

CompositingRecorder::endCompositing has an optimization [1] to turn
patterns like [..., begin compositing, drawing, end compositing]
into [..., composited drawing] which takes advantage of an SkPicture
recording optimization. An SkPictureBuilder is not needed in this
case, as we can modify the underlying display list while creating the
new composited drawing. To do this, a DCHECK in DrawingRecorder that
the underlying list doesn't change has been suppressed with
DisableListModificationCheck.

The last user of DisableNullPaintPropertyChecks has been removed which
lets us delete code from PaintChunker.

[1] https://codereview.chromium.org/2186643002

BUG=628831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[pdr., 2017-02-03 00:12:06]

On 2017/02/02 at 23:52:07, chrishtr wrote:
>
https://codereview.chromium.org/2675773003/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp
(left):
> 
>
https://codereview.chromium.org/2675773003/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/graphics/paint/DrawingRecorder.cpp:78:
DCHECK(m_displayItemPosition ==
> This DCHECK still seems generally useful. Pass an extra arg
> to suppress it for CompositingRecorder?

Good idea, done.

Also removed DisableNullPaintPropertyChecks which is no longer used.

[chrishtr, 2017-02-03 00:20:42]

lgtm

[pdr., 2017-02-03 00:22:47]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-02-03 00:23:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 00:25:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 00:25:16]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[pdr., 2017-02-03 00:56:52]

The CQ bit was checked by pdr@chromium.org

[pdr., 2017-02-03 00:56:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2675773003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-03 00:57:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 03:31:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486083412043630,
"parent_rev": "4ef35706c091a8f8f18fbee2c5672831ad24ecea", "commit_rev":
"424a2d302d2106dabd248ee96ab751bd54d38f1a"}

[commit-bot: I haz the power, 2017-02-03 03:34:54]

Description was changed from

==========
Optimize CompositingRecorder::endCompositing to not need an SkPictureBuilder

CompositingRecorder::endCompositing has an optimization [1] to turn
patterns like [..., begin compositing, drawing, end compositing]
into [..., composited drawing] which takes advantage of an SkPicture
recording optimization. An SkPictureBuilder is not needed in this
case, as we can modify the underlying display list while creating the
new composited drawing. To do this, a DCHECK in DrawingRecorder that
the underlying list doesn't change has been suppressed with
DisableListModificationCheck.

The last user of DisableNullPaintPropertyChecks has been removed which
lets us delete code from PaintChunker.

[1] https://codereview.chromium.org/2186643002

BUG=628831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Optimize CompositingRecorder::endCompositing to not need an SkPictureBuilder

CompositingRecorder::endCompositing has an optimization [1] to turn
patterns like [..., begin compositing, drawing, end compositing]
into [..., composited drawing] which takes advantage of an SkPicture
recording optimization. An SkPictureBuilder is not needed in this
case, as we can modify the underlying display list while creating the
new composited drawing. To do this, a DCHECK in DrawingRecorder that
the underlying list doesn't change has been suppressed with
DisableListModificationCheck.

The last user of DisableNullPaintPropertyChecks has been removed which
lets us delete code from PaintChunker.

[1] https://codereview.chromium.org/2186643002

BUG=628831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2675773003
Cr-Commit-Position: refs/heads/master@{#447903}
Committed:
https://chromium.googlesource.com/chromium/src/+/424a2d302d2106dabd248ee96ab7...
==========

[commit-bot: I haz the power, 2017-02-03 03:34:56]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/424a2d302d2106dabd248ee96ab7...

[danakj, 2017-02-03 18:14:54]

Thanks so much this is so much more easy to follow. LGTM too