Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2675763004: Add an URLRequestTest to test the quic server info factory setup at the creation of HttpCache. (Closed)

Created:
3 years, 10 months ago by Zhongyi Shi
Modified:
3 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an URLRequestTest to test the quic server info factory setup at the creation of HttpCache. BUG=686632 Review-Url: https://codereview.chromium.org/2675763004 Cr-Commit-Position: refs/heads/master@{#448031} Committed: https://chromium.googlesource.com/chromium/src/+/18ddddd18ab835e13d69cc78e108a2f55a4a5f30

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -3 lines) Patch
M net/http/mock_http_cache.h View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 1 chunk +5 lines, -1 line 0 comments Download
M net/url_request/url_request_unittest.cc View 5 chunks +126 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Zhongyi Shi
3 years, 10 months ago (2017-02-03 05:02:25 UTC) #2
Ryan Hamilton
lgtm
3 years, 10 months ago (2017-02-03 18:32:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675763004/1
3 years, 10 months ago (2017-02-03 18:37:03 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 19:07:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/18ddddd18ab835e13d69cc78e108...

Powered by Google App Engine
This is Rietveld 408576698