Adapt String::find method via StringUtil adapter. [v8 repo]

Adapt String::find method via StringUtil adapter.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will rename wtf::StringBuilder::find method into Find).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new StringUtil::find adapter method:
rolling third_party/inspector to 1a7cbe8ba8fa0d622586f549a97c73d9b52efbea

BUG=683447
Review-Url: https://codereview.chromium.org/2675763003
Cr-Commit-Position: refs/heads/master@{#42936}
Committed: https://chromium.googlesource.com/v8/v8/+/de20581ca37011d6ef9490b6c3f25c1a594ab200

[Łukasz Anforowicz, 2017-02-02 17:47:35]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 17:47:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 18:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 18:25:21]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2017-02-02 18:26:15]

Description was changed from

==========
Adapt String::find method via StringUtil adapter.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will rename wtf::StringBuilder::find method into Find).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new StringUtil::find adapter method:
rolling third_party/inspector to
DO NOT SUBMIT / TODO / FIXME - revision number goes here.

BUG=683447
==========

to

==========
Adapt String::find method via StringUtil adapter.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will rename wtf::StringBuilder::find method into Find).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new StringUtil::find adapter method:
rolling third_party/inspector to
DO NOT SUBMIT / TODO / FIXME - revision number goes here.

BUG=683447
==========

[Łukasz Anforowicz, 2017-02-02 18:32:16]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 18:32:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 19:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 19:20:04]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2017-02-02 21:19:38]

lukasza@chromium.org changed reviewers:
+ dgozman@chromium.org

[Łukasz Anforowicz, 2017-02-02 21:19:39]

dgozman@, could you PTAL?

[dgozman, 2017-02-03 20:43:39]

lgtm

https://codereview.chromium.org/2675763003/diff/20001/src/inspector/string-ut...
File src/inspector/string-util.h (right):

https://codereview.chromium.org/2675763003/diff/20001/src/inspector/string-ut...
src/inspector/string-util.h:35: static size_t find(const String& s, const char*
needle) {
Let's also have |const String& needle| version.

[Łukasz Anforowicz, 2017-02-03 21:51:54]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 21:51:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-02-03 21:53:35]

Description was changed from

==========
Adapt String::find method via StringUtil adapter.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will rename wtf::StringBuilder::find method into Find).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new StringUtil::find adapter method:
rolling third_party/inspector to
DO NOT SUBMIT / TODO / FIXME - revision number goes here.

BUG=683447
==========

to

==========
Adapt String::find method via StringUtil adapter.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will rename wtf::StringBuilder::find method into Find).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new StringUtil::find adapter method:
rolling third_party/inspector to 1a7cbe8ba8fa0d622586f549a97c73d9b52efbea

BUG=683447
==========

[Łukasz Anforowicz, 2017-02-03 21:56:21]

Thank you for the review.

https://codereview.chromium.org/2675763003/diff/20001/src/inspector/string-ut...
File src/inspector/string-util.h (right):

https://codereview.chromium.org/2675763003/diff/20001/src/inspector/string-ut...
src/inspector/string-util.h:35: static size_t find(const String& s, const char*
needle) {
On 2017/02/03 20:43:39, dgozman (OOO till Feb 13) wrote:
> Let's also have |const String& needle| version.

Done.

[Łukasz Anforowicz, 2017-02-03 22:00:38]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-02-03 22:00:44]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-02-03 22:00:45]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2675763003/#ps60001
(title: "Update revision hash for inspector_protocol repo.")

[commit-bot: I haz the power, 2017-02-03 22:00:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 22:17:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486159244667220,
"parent_rev": "6b6ed60155314fc608504b235382909ebedc23d8", "commit_rev":
"de20581ca37011d6ef9490b6c3f25c1a594ab200"}

[commit-bot: I haz the power, 2017-02-03 22:17:30]

Description was changed from

==========
Adapt String::find method via StringUtil adapter.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will rename wtf::StringBuilder::find method into Find).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new StringUtil::find adapter method:
rolling third_party/inspector to 1a7cbe8ba8fa0d622586f549a97c73d9b52efbea

BUG=683447
==========

to

==========
Adapt String::find method via StringUtil adapter.

This is needed to insulate generated code from blink::protocol namespace
from naming changes that we plan to do in the Great Blink Rename (which
in particular will rename wtf::StringBuilder::find method into Find).

This CL also includes roll of inspector_protocol which starts to
generate code that uses the new StringUtil::find adapter method:
rolling third_party/inspector to 1a7cbe8ba8fa0d622586f549a97c73d9b52efbea

BUG=683447

Review-Url: https://codereview.chromium.org/2675763003
Cr-Commit-Position: refs/heads/master@{#42936}
Committed:
https://chromium.googlesource.com/v8/v8/+/de20581ca37011d6ef9490b6c3f25c1a594...
==========

[commit-bot: I haz the power, 2017-02-03 22:17:31]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/de20581ca37011d6ef9490b6c3f25c1a594...