Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2675753004:
[system-health] Re-enable browse:news:{hackernews, nytimes} in mobile smoke test (Closed)
Description[system-health] Re-enable browse:news:{hackernews, nytimes} in mobile smoke test
BUG=629123
patch from issue 2244283002 at patchset 1 (http://crrev.com/2244283002#ps1)
Review-Url: https://codereview.chromium.org/2675753004
Cr-Commit-Position: refs/heads/master@{#448015}
Committed: https://chromium.googlesource.com/chromium/src/+/d262a0940e4985ed70f3954e9cf596adcf1b4a2a
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
The CQ bit was checked by hjd@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hjd@chromium.org changed reviewers: + perezju@chromium.org
ptal, also do you know which bot runs the smoke tests? I can't work out if I've run this or not...
perezju@chromium.org changed reviewers: + nednguyen@google.com
On 2017/02/03 17:06:28, hjd wrote: > ptal, also do you know which bot runs the smoke tests? I can't work out if I've > run this or not... I think Ned should be able to answer these.
On 2017/02/03 17:09:05, perezju wrote: > On 2017/02/03 17:06:28, hjd wrote: > > ptal, also do you know which bot runs the smoke tests? I can't work out if > I've > > run this or not... > > I think Ned should be able to answer these. telemetry_perf_unittests in android_n5x_swarming_rel
On 2017/02/03 17:10:38, nednguyen wrote: > On 2017/02/03 17:09:05, perezju wrote: > > On 2017/02/03 17:06:28, hjd wrote: > > > ptal, also do you know which bot runs the smoke tests? I can't work out if > > I've > > > run this or not... > > > > I think Ned should be able to answer these. > > telemetry_perf_unittests in android_n5x_swarming_rel the change itself lgtm if Ned is happy
On 2017/02/03 17:10:38, nednguyen wrote: > On 2017/02/03 17:09:05, perezju wrote: > > On 2017/02/03 17:06:28, hjd wrote: > > > ptal, also do you know which bot runs the smoke tests? I can't work out if > > I've > > > run this or not... > > > > I think Ned should be able to answer these. > > telemetry_perf_unittests in android_n5x_swarming_rel In that case it looks like it is passing now? Shall we go ahead and re-enable?
totally lgtm No need to wait for my stamp in test reenable CL anyway :)
On 2017/02/03 17:18:27, nednguyen wrote: > totally lgtm > > No need to wait for my stamp in test reenable CL anyway :) Thanks both! :)
The CQ bit was checked by hjd@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486142420609790, "parent_rev":
"d8fafb98e8e3a3829e6671432e2e5782242d9121", "commit_rev":
"d262a0940e4985ed70f3954e9cf596adcf1b4a2a"}
Message was sent while issue was closed.
Description was changed from
==========
[system-health] Re-enable browse:news:{hackernews, nytimes} in mobile smoke test
BUG=629123
patch from issue 2244283002 at patchset 1 (http://crrev.com/2244283002#ps1)
==========
to
==========
[system-health] Re-enable browse:news:{hackernews, nytimes} in mobile smoke test
BUG=629123
patch from issue 2244283002 at patchset 1 (http://crrev.com/2244283002#ps1)
Review-Url: https://codereview.chromium.org/2675753004
Cr-Commit-Position: refs/heads/master@{#448015}
Committed:
https://chromium.googlesource.com/chromium/src/+/d262a0940e4985ed70f3954e9cf5...
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d262a0940e4985ed70f3954e9cf5... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
