Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2675753003: cc: Delete old YUV code (Closed)

Created:
3 years, 10 months ago by ccameron
Modified:
3 years, 10 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Delete old YUV code The previous patches added DCHECKs that the matrices used in the old path and the new path were within 1/256 of each other. This patch deletes the old path, and rebaselines a couple of images which are marinally different due to rounding error. BUG=667966 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2675753003 Cr-Commit-Position: refs/heads/master@{#448215} Committed: https://chromium.googlesource.com/chromium/src/+/cf72df57524576aec7e502b06c2d2994a56f05d4

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update LayoutTestExpecatations #

Patch Set 3 : More test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -102 lines) Patch
M cc/output/gl_renderer.cc View 3 chunks +1 line, -90 lines 0 comments Download
M cc/test/data/intersecting_blue_green_squares_video.png View Binary file 0 comments Download
M cc/test/data/yuv_stripes_offset.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +39 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
ccameron
ptal -- small (and very careful) patch https://codereview.chromium.org/2675753003/diff/1/cc/output/gl_renderer.cc File cc/output/gl_renderer.cc (right): https://codereview.chromium.org/2675753003/diff/1/cc/output/gl_renderer.cc#newcode2103 cc/output/gl_renderer.cc:2103: // one ...
3 years, 10 months ago (2017-02-03 02:58:59 UTC) #4
enne (OOO)
lgtm
3 years, 10 months ago (2017-02-03 17:27:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675753003/20001
3 years, 10 months ago (2017-02-05 19:36:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/builds/4562)
3 years, 10 months ago (2017-02-05 20:52:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675753003/40001
3 years, 10 months ago (2017-02-06 03:04:25 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 05:45:06 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cf72df57524576aec7e502b06c2d...

Powered by Google App Engine
This is Rietveld 408576698