Assert when building Asan on windows in debug mode

Assert when building Asan on windows in debug mode

R=ochang@chromium.org, rnk@chromium.org, chrisha@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2675753002
Cr-Commit-Position: refs/heads/master@{#447803}
Committed: https://chromium.googlesource.com/chromium/src/+/5e86b62256b5d7cdc7a10f57c06a1b040e2bbede

[etienneb, 2017-02-02 16:32:02]

Description was changed from

==========
Assert when building Asan on windows in debug mode

BUG=ochang@chromium.org, rnk@chromium.org, chrisha@chromium.org
==========

to

==========
Assert when building Asan on windows in debug mode

R=ochang@chromium.org, rnk@chromium.org, chrisha@chromium.org
BUG=
==========

[etienneb, 2017-02-02 16:32:02]

etienneb@chromium.org changed reviewers:
+ chrisha@chromium.org, ochang@chromium.org, rnk@chromium.org

[etienneb, 2017-02-02 16:32:19]

PTAL.

[Reid Kleckner, 2017-02-02 16:52:29]

https://codereview.chromium.org/2675753002/diff/1/build/config/sanitizers/san...
File build/config/sanitizers/sanitizers.gni (right):

https://codereview.chromium.org/2675753002/diff/1/build/config/sanitizers/san...
build/config/sanitizers/sanitizers.gni:191: "ASan on Windows doesn't work in
release (set is_debug=false).")
"doesn't work in debug" (not release)

[etienneb, 2017-02-02 16:56:01]

ouf, copy paste is bad! thx rnk.

[Oliver Chang, 2017-02-02 17:06:29]

lgtm

[etienneb, 2017-02-02 17:24:04]

The CQ bit was checked by etienneb@chromium.org

[commit-bot: I haz the power, 2017-02-02 17:24:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 18:38:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486056244164630,
"parent_rev": "f5e04ad29b1ef9e8bf180191ef57120163faa0a1", "commit_rev":
"5e86b62256b5d7cdc7a10f57c06a1b040e2bbede"}

[commit-bot: I haz the power, 2017-02-02 18:38:39]

Description was changed from

==========
Assert when building Asan on windows in debug mode

R=ochang@chromium.org, rnk@chromium.org, chrisha@chromium.org
BUG=
==========

to

==========
Assert when building Asan on windows in debug mode

R=ochang@chromium.org, rnk@chromium.org, chrisha@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2675753002
Cr-Commit-Position: refs/heads/master@{#447803}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e86b62256b5d7cdc7a10f57c06a...
==========

[commit-bot: I haz the power, 2017-02-02 18:38:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5e86b62256b5d7cdc7a10f57c06a...