Improve NetLog HTTP/2 event names.

Improve NetLog HTTP/2 event names.

s/HTTP2_SESSION_RST_STREAM/HTTP2_SESSION_RECV_RST_STREAM/ to make it obvious
that a frame is received.  Sending event is already called _SEND_RST_STREAM.

Split NetLogSpdyRstCallback() into NetLogSpdyRecvRstStreamCallback() and
NetLogSpdySendRstStreamCallback(), and remove |description| argument from
NetLogSpdyRecvRstStreamCallback().  (This is leftover from earlier SPDY versions
that allowed RST_STREAM fields to carry a description.  HTTP/2 does not allow
this, and NetLogSpdyRstCallback() was always called with an empty description
when a RST_STREAM frame was received.)

Similarily, s/HTTP2_SESSION_GOAWAY/HTTP2_SESSION_RECV_GOAWAY/.  Note that there
is no HTTP2_SESSION_SEND_GOAWAY: instead a HTTP2_SESSION_CLOSE is logged.

Since there were already five HTTP2_SESSION_RECV_ events and this CL adds two
more, also change _RECEIVED_ to _RECV_ in HTTP2_SESSION_RECEIVED_WINDOW_UPDATE_FRAME.

Since there were already four HTTP2_SESSION_SEND_ events, also change _SENT_ to
_SEND_ in HTTP2_SESSION_SENT_WINDOW_UPDATE_FRAME.

Since there are event names for HEADERS, SETTINGS, RST_STREAM, PING, GOAWAY,
DATA, and PUSH_PROMISE frames without _FRAME suffix, also remove such suffix from
HTTP2_SESSION_RECV_WINDOW_UPDATE_FRAME and HTTP2_SESSION_SEND_WINDOW_UPDATE_FRAME.

Review-Url: https://codereview.chromium.org/2675723003
Cr-Commit-Position: refs/heads/master@{#448038}
Committed: https://chromium.googlesource.com/chromium/src/+/d8d7e0da939d5a60057549c99b2bcee3b9eb28db

[Bence, 2017-02-03 00:25:26]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 00:25:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 01:36:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 01:36:40]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-02-03 01:57:30]

bnc@chromium.org changed reviewers:
+ mgersh@chromium.org

[Bence, 2017-02-03 01:57:31]

mgersh: Would you like to do a first pass review if you have free cycles?  Thank
you.

[eroman, 2017-02-03 02:02:09]

eroman@chromium.org changed reviewers:
+ eroman@chromium.org

[eroman, 2017-02-03 02:02:10]

lgtm

https://codereview.chromium.org/2675723003/diff/1/net/log/net_log_event_type_...
File net/log/net_log_event_type_list.h (right):

https://codereview.chromium.org/2675723003/diff/1/net/log/net_log_event_type_...
net/log/net_log_event_type_list.h:1409:
EVENT_TYPE(HTTP2_SESSION_RECEIVED_WINDOW_UPDATE_FRAME)
If you are normalizing on "RECV_" then should you update this for consistency
too?

[Bence, 2017-02-03 13:11:05]

Patchset #2 (id:20001) has been deleted

[Bence, 2017-02-03 13:49:40]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 13:50:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-02-03 13:53:54]

Description was changed from

==========
Improve NetLog HTTP/2 RST_STREAM and GOAWAY receiving event names.

s/HTTP2_SESSION_RST_STREAM/HTTP2_SESSION_RECV_RST_STREAM/ to make it obvious
that a frame is received.  Sending event is already called _SEND_RST_STREAM.

Split NetLogSpdyRstCallback() into NetLogSpdyRecvRstStreamCallback() and
NetLogSpdySendRstStreamCallback(), and remove |description| argument from
NetLogSpdyRecvRstStreamCallback().  (This is leftover from earlier SPDY versions
that allowed RST_STREAM fields to carry a description.  HTTP/2 does not allow
this, and NetLogSpdyRstCallback() was always called with an empty description
when a RST_STREAM frame was received.)

Similarily, s/HTTP2_SESSION_GOAWAY/HTTP2_SESSION_RECV_GOAWAY/.  Note that there
is no HTTP2_SESSION_SEND_GOAWAY: instead a HTTP2_SESSION_CLOSE is logged.
==========

to

==========
Improve NetLog HTTP/2 event names.

s/HTTP2_SESSION_RST_STREAM/HTTP2_SESSION_RECV_RST_STREAM/ to make it obvious
that a frame is received.  Sending event is already called _SEND_RST_STREAM.

Split NetLogSpdyRstCallback() into NetLogSpdyRecvRstStreamCallback() and
NetLogSpdySendRstStreamCallback(), and remove |description| argument from
NetLogSpdyRecvRstStreamCallback().  (This is leftover from earlier SPDY versions
that allowed RST_STREAM fields to carry a description.  HTTP/2 does not allow
this, and NetLogSpdyRstCallback() was always called with an empty description
when a RST_STREAM frame was received.)

Similarily, s/HTTP2_SESSION_GOAWAY/HTTP2_SESSION_RECV_GOAWAY/.  Note that there
is no HTTP2_SESSION_SEND_GOAWAY: instead a HTTP2_SESSION_CLOSE is logged.

Since there were already five HTTP2_SESSION_RECV_ events and this CL adds two
more, also change _RECEIVED_ to _RECV_ in
HTTP2_SESSION_RECEIVED_WINDOW_UPDATE_FRAME.

Since there were already four HTTP2_SESSION_SEND_ events, also change _SENT_ to
_SEND_ in HTTP2_SESSION_SENT_WINDOW_UPDATE_FRAME.

Since there are event names for HEADERS, SETTINGS, RST_STREAM, PING, GOAWAY,
DATA, and PUSH_PROMISE frames without _FRAME suffix, also remove such suffix
from
HTTP2_SESSION_RECV_WINDOW_UPDATE_FRAME and
HTTP2_SESSION_SEND_WINDOW_UPDATE_FRAME.
==========

[commit-bot: I haz the power, 2017-02-03 15:03:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 15:03:41]

Dry run: This issue passed the CQ dry run.

[Bence, 2017-02-03 15:09:44]

PTAL.

https://codereview.chromium.org/2675723003/diff/1/net/log/net_log_event_type_...
File net/log/net_log_event_type_list.h (right):

https://codereview.chromium.org/2675723003/diff/1/net/log/net_log_event_type_...
net/log/net_log_event_type_list.h:1409:
EVENT_TYPE(HTTP2_SESSION_RECEIVED_WINDOW_UPDATE_FRAME)
On 2017/02/03 02:02:09, eroman (slow) wrote:
> If you are normalizing on "RECV_" then should you update this for consistency
> too?

Done.  Also s/SENT/SEND/;s/_FRAME$//

[mgersh, 2017-02-03 15:50:18]

lgtm

[Bence, 2017-02-03 16:18:28]

On 2017/02/03 15:50:18, mgersh wrote:
> lgtm

Thank you.  Since Eric l-g-t-m'ed earlier (with nits), I'm submitting this now.

[Bence, 2017-02-03 16:18:33]

The CQ bit was checked by bnc@chromium.org

[Bence, 2017-02-03 16:18:33]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2675723003/#ps40001
(title: "Change some more event names.")

[commit-bot: I haz the power, 2017-02-03 16:18:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 16:24:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 16:24:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Bence, 2017-02-03 18:11:34]

The CQ bit was checked by bnc@chromium.org

[Bence, 2017-02-03 18:11:35]

The patchset sent to the CQ was uploaded after l-g-t-m from mgersh@chromium.org,
eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2675723003/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-02-03 18:12:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 19:19:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486145494717360,
"parent_rev": "fb710b631287aea4df1536d05046e750184a7bda", "commit_rev":
"d8d7e0da939d5a60057549c99b2bcee3b9eb28db"}

[commit-bot: I haz the power, 2017-02-03 19:20:33]

Description was changed from

==========
Improve NetLog HTTP/2 event names.

s/HTTP2_SESSION_RST_STREAM/HTTP2_SESSION_RECV_RST_STREAM/ to make it obvious
that a frame is received.  Sending event is already called _SEND_RST_STREAM.

Split NetLogSpdyRstCallback() into NetLogSpdyRecvRstStreamCallback() and
NetLogSpdySendRstStreamCallback(), and remove |description| argument from
NetLogSpdyRecvRstStreamCallback().  (This is leftover from earlier SPDY versions
that allowed RST_STREAM fields to carry a description.  HTTP/2 does not allow
this, and NetLogSpdyRstCallback() was always called with an empty description
when a RST_STREAM frame was received.)

Similarily, s/HTTP2_SESSION_GOAWAY/HTTP2_SESSION_RECV_GOAWAY/.  Note that there
is no HTTP2_SESSION_SEND_GOAWAY: instead a HTTP2_SESSION_CLOSE is logged.

Since there were already five HTTP2_SESSION_RECV_ events and this CL adds two
more, also change _RECEIVED_ to _RECV_ in
HTTP2_SESSION_RECEIVED_WINDOW_UPDATE_FRAME.

Since there were already four HTTP2_SESSION_SEND_ events, also change _SENT_ to
_SEND_ in HTTP2_SESSION_SENT_WINDOW_UPDATE_FRAME.

Since there are event names for HEADERS, SETTINGS, RST_STREAM, PING, GOAWAY,
DATA, and PUSH_PROMISE frames without _FRAME suffix, also remove such suffix
from
HTTP2_SESSION_RECV_WINDOW_UPDATE_FRAME and
HTTP2_SESSION_SEND_WINDOW_UPDATE_FRAME.
==========

to

==========
Improve NetLog HTTP/2 event names.

s/HTTP2_SESSION_RST_STREAM/HTTP2_SESSION_RECV_RST_STREAM/ to make it obvious
that a frame is received.  Sending event is already called _SEND_RST_STREAM.

Split NetLogSpdyRstCallback() into NetLogSpdyRecvRstStreamCallback() and
NetLogSpdySendRstStreamCallback(), and remove |description| argument from
NetLogSpdyRecvRstStreamCallback().  (This is leftover from earlier SPDY versions
that allowed RST_STREAM fields to carry a description.  HTTP/2 does not allow
this, and NetLogSpdyRstCallback() was always called with an empty description
when a RST_STREAM frame was received.)

Similarily, s/HTTP2_SESSION_GOAWAY/HTTP2_SESSION_RECV_GOAWAY/.  Note that there
is no HTTP2_SESSION_SEND_GOAWAY: instead a HTTP2_SESSION_CLOSE is logged.

Since there were already five HTTP2_SESSION_RECV_ events and this CL adds two
more, also change _RECEIVED_ to _RECV_ in
HTTP2_SESSION_RECEIVED_WINDOW_UPDATE_FRAME.

Since there were already four HTTP2_SESSION_SEND_ events, also change _SENT_ to
_SEND_ in HTTP2_SESSION_SENT_WINDOW_UPDATE_FRAME.

Since there are event names for HEADERS, SETTINGS, RST_STREAM, PING, GOAWAY,
DATA, and PUSH_PROMISE frames without _FRAME suffix, also remove such suffix
from
HTTP2_SESSION_RECV_WINDOW_UPDATE_FRAME and
HTTP2_SESSION_SEND_WINDOW_UPDATE_FRAME.

Review-Url: https://codereview.chromium.org/2675723003
Cr-Commit-Position: refs/heads/master@{#448038}
Committed:
https://chromium.googlesource.com/chromium/src/+/d8d7e0da939d5a60057549c99b2b...
==========

[commit-bot: I haz the power, 2017-02-03 19:20:35]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d8d7e0da939d5a60057549c99b2b...