Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/front_end/lib/src/fasta/source/source_loader.dart

Issue 2675603002: Reduce strong mode errors and warnings (Closed)
Patch Set: comments & cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/front_end/lib/src/fasta/source/outline_builder.dart ('K') | « pkg/front_end/lib/src/fasta/source/source_library_builder.dart ('k') | pkg/front_end/lib/src/fasta/source/stack_listener.dart » ('j') | pkg/front_end/lib/src/fasta/source/stack_listener.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/source/source_loader.dart
diff --git a/pkg/front_end/lib/src/fasta/source/source_loader.dart b/pkg/front_end/lib/src/fasta/source/source_loader.dart
index f50f8ddbd87ddfed8edba92588b2a2a5a0dd566d..0f1d32a98ea7f45d8c699510fa84d74e0b9e8a8b 100644
--- a/pkg/front_end/lib/src/fasta/source/source_loader.dart
+++ b/pkg/front_end/lib/src/fasta/source/source_loader.dart
@@ -197,7 +197,8 @@ class SourceLoader<L> extends Loader<L> {
}
void debugPrintExports() {
- builders.forEach((Uri uri, SourceLibraryBuilder library) {
+ // TODO(sigmund): should be covaraint SourceLibraryBuilder
ahe 2017/02/07 11:03:08 covariant.
Siggi Cherem (dart-lang) 2017/02/07 21:59:26 Done.
+ builders.forEach((Uri uri, dynamic library) {
Set<Builder> members = new Set<Builder>();
library.members.forEach((String name, Builder member) {
while (member != null) {
« pkg/front_end/lib/src/fasta/source/outline_builder.dart ('K') | « pkg/front_end/lib/src/fasta/source/source_library_builder.dart ('k') | pkg/front_end/lib/src/fasta/source/stack_listener.dart » ('j') | pkg/front_end/lib/src/fasta/source/stack_listener.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698