Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: pkg/front_end/lib/src/fasta/source/source_loader.dart

Issue 2675603002: Reduce strong mode errors and warnings (Closed)
Patch Set: comments & cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.source_loader; 5 library fasta.source_loader;
6 6
7 import 'dart:async' show 7 import 'dart:async' show
8 Future; 8 Future;
9 9
10 import 'dart:io' show 10 import 'dart:io' show
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 builders.forEach((Uri uri, LibraryBuilder library) { 190 builders.forEach((Uri uri, LibraryBuilder library) {
191 if (library is SourceLibraryBuilder) { 191 if (library is SourceLibraryBuilder) {
192 library.addImportsToScope(); 192 library.addImportsToScope();
193 } 193 }
194 }); 194 });
195 ticker.logMs("Computed library scopes"); 195 ticker.logMs("Computed library scopes");
196 // debugPrintExports(); 196 // debugPrintExports();
197 } 197 }
198 198
199 void debugPrintExports() { 199 void debugPrintExports() {
200 builders.forEach((Uri uri, SourceLibraryBuilder library) { 200 // TODO(sigmund): should be covaraint SourceLibraryBuilder
ahe 2017/02/07 11:03:08 covariant.
Siggi Cherem (dart-lang) 2017/02/07 21:59:26 Done.
201 builders.forEach((Uri uri, dynamic library) {
201 Set<Builder> members = new Set<Builder>(); 202 Set<Builder> members = new Set<Builder>();
202 library.members.forEach((String name, Builder member) { 203 library.members.forEach((String name, Builder member) {
203 while (member != null) { 204 while (member != null) {
204 members.add(member); 205 members.add(member);
205 member = member.next; 206 member = member.next;
206 } 207 }
207 }); 208 });
208 List<String> exports = <String>[]; 209 List<String> exports = <String>[];
209 library.exports.forEach((String name, Builder member) { 210 library.exports.forEach((String name, Builder member) {
210 while (member != null) { 211 while (member != null) {
(...skipping 135 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 ticker.logMs("Built analyzer element model."); 347 ticker.logMs("Built analyzer element model.");
347 } 348 }
348 349
349 void computeHierarchy(Program program) { 350 void computeHierarchy(Program program) {
350 hierarchy = new ClassHierarchy(program); 351 hierarchy = new ClassHierarchy(program);
351 ticker.logMs("Computed class hierarchy"); 352 ticker.logMs("Computed class hierarchy");
352 coreTypes = new CoreTypes(program); 353 coreTypes = new CoreTypes(program);
353 ticker.logMs("Computed core types"); 354 ticker.logMs("Computed core types");
354 } 355 }
355 } 356 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698