[MD Bookmarks] Remove Multiple Selected Items.

[MD Bookmarks]Remove Multiple Selected Items.

This CL enables removing multiple selected items by clicking the delete button
in the dropdown menu on any selected items.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

[jiaxi, 2017-02-01 23:27:52]

Description was changed from

==========
[MD Bookmarks]Remove Multiple Selected Items

This CL enables removing multiple selected items by clicking the delete button
in the dropdown menu on any selected items.

BUG=658980
==========

to

==========
[MD Bookmarks]Remove Multiple Selected Items

This CL enables removing multiple selected items by clicking the delete button
in the dropdown menu on any selected items.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jiaxi, 2017-02-01 23:28:07]

Description was changed from

==========
[MD Bookmarks]Remove Multiple Selected Items

This CL enables removing multiple selected items by clicking the delete button
in the dropdown menu on any selected items.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Bookmarks]Remove Multiple Selected Items.

This CL enables removing multiple selected items by clicking the delete button
in the dropdown menu on any selected items.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jiaxi, 2017-02-01 23:30:03]

Patchset #1 (id:1) has been deleted

[jiaxi, 2017-02-01 23:32:12]

jiaxi@google.com changed reviewers:
+ angelayang@google.com, calamity@chromium.org, tsergeant@chromium.org

[jiaxi, 2017-02-01 23:32:13]

https://codereview.chromium.org/2675503002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/store.js (right):

https://codereview.chromium.org/2675503002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:468:
this.removeSingleItem_(itemsToRemoved[i]);
This probably needs a test but I'm not sure how to write it. Should we just
multiple select items, add onRemoved listeners that adds a counter and just
check how many times the onRemoved has been called?

[tsergeant, 2017-02-02 02:12:16]

https://codereview.chromium.org/2675503002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/store.js (right):

https://codereview.chromium.org/2675503002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:468:
this.removeSingleItem_(itemsToRemoved[i]);
On 2017/02/01 23:32:13, jiaxi wrote:
> This probably needs a test but I'm not sure how to write it. Should we just
> multiple select items, add onRemoved listeners that adds a counter and just
> check how many times the onRemoved has been called?

That sounds like a reasonable way to do it.

[jiaxi, 2017-02-02 04:30:54]

Patchset #2 (id:40001) has been deleted

[jiaxi, 2017-02-02 05:37:19]

https://codereview.chromium.org/2675503002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/store.js (right):

https://codereview.chromium.org/2675503002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/store.js:468:
this.removeSingleItem_(itemsToRemoved[i]);
On 2017/02/02 02:12:15, tsergeant wrote:
> On 2017/02/01 23:32:13, jiaxi wrote:
> > This probably needs a test but I'm not sure how to write it. Should we just
> > multiple select items, add onRemoved listeners that adds a counter and just
> > check how many times the onRemoved has been called?
> 
> That sounds like a reasonable way to do it.

Done.