Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2675483003: [Sensors] Introduce 'unconnected' sensor state (Closed)

Created:
3 years, 10 months ago by Mikhail
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews, wanming.lin, shalamov, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Introduce 'unconnected' sensor state As described in Generic Sensor specification (https://w3c.github.io/sensors/#dom-sensorstate-unconnected). BUG=606766 Review-Url: https://codereview.chromium.org/2675483003 Cr-Commit-Position: refs/heads/master@{#447988} Committed: https://chromium.googlesource.com/chromium/src/+/80e2a4ce4a074b27512bcc4ae97bdc7eaed2a8c5

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js View 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 1 5 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.idl View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
Mikhail
PTAL
3 years, 10 months ago (2017-02-02 15:22:16 UTC) #5
Reilly Grant (use Gerrit)
lgtm
3 years, 10 months ago (2017-02-02 17:35:24 UTC) #6
haraken
LGTM
3 years, 10 months ago (2017-02-03 04:13:50 UTC) #9
shalamov
lgtm
3 years, 10 months ago (2017-02-03 07:05:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675483003/1
3 years, 10 months ago (2017-02-03 08:26:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/356152)
3 years, 10 months ago (2017-02-03 08:31:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675483003/20001
3 years, 10 months ago (2017-02-03 11:45:36 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 14:05:06 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/80e2a4ce4a074b27512bcc4ae97b...

Powered by Google App Engine
This is Rietveld 408576698