Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2675453002: Language settings: Fix unnecessarily shown move buttons (Closed)
Patch Set: nit Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/languages_page/languages_page.html
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html
index 9ceaba44b76df7e5eb4c30b5d057402d2fbdeb15..762022299186c1f6742241615d5edbf08104afee 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.html
+++ b/chrome/browser/resources/settings/languages_page/languages_page.html
@@ -245,19 +245,18 @@
<hr>
<button class="dropdown-item" role="menuitem"
on-tap="onMoveToTopTap_"
- hidden="[[isFirstLanguage_(
- detailLanguage_, languages.enabled.*)]]">
+ hidden="[[isNthLanguage_(
+ 0, detailLanguage_, languages.enabled.*)]]">
$i18n{moveToTop}
</button>
<button class="dropdown-item" role="menuitem"
on-tap="onMoveUpTap_"
- hidden="[[isFirstOrSecondLanguage_(
- detailLanguage_, languages.enabled.*)]]">
+ hidden="[[!showMoveUp_(detailLanguage_, languages.enabled.*)]]">
$i18n{moveUp}
</button>
<button class="dropdown-item" role="menuitem"
on-tap="onMoveDownTap_"
- hidden="[[isLastLanguage_(
+ hidden="[[!showMoveDown_(
detailLanguage_, languages.enabled.*)]]">
$i18n{moveDown}
</button>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698