Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2675453002: Language settings: Fix unnecessarily shown move buttons (Closed)
Patch Set: nit Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/action_link.html"> 1 <link rel="import" href="chrome://resources/html/action_link.html">
2 <link rel="import" href="chrome://resources/html/action_link_css.html"> 2 <link rel="import" href="chrome://resources/html/action_link_css.html">
3 <link rel="import" href="chrome://resources/html/assert.html"> 3 <link rel="import" href="chrome://resources/html/assert.html">
4 <link rel="import" href="chrome://resources/html/cr.html"> 4 <link rel="import" href="chrome://resources/html/cr.html">
5 <link rel="import" href="chrome://resources/html/polymer.html"> 5 <link rel="import" href="chrome://resources/html/polymer.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
10 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 10 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 checked="[[detailLanguage_.translateEnabled]]" 238 checked="[[detailLanguage_.translateEnabled]]"
239 on-change="onTranslateCheckboxChange_" 239 on-change="onTranslateCheckboxChange_"
240 hidden="[[!prefs.translate.enabled.value]]" 240 hidden="[[!prefs.translate.enabled.value]]"
241 disabled="[[disableTranslateCheckbox_( 241 disabled="[[disableTranslateCheckbox_(
242 detailLanguage_.language, languages.translateTarget)]]"> 242 detailLanguage_.language, languages.translateTarget)]]">
243 $i18n{offerToTranslateInThisLanguage} 243 $i18n{offerToTranslateInThisLanguage}
244 </paper-checkbox> 244 </paper-checkbox>
245 <hr> 245 <hr>
246 <button class="dropdown-item" role="menuitem" 246 <button class="dropdown-item" role="menuitem"
247 on-tap="onMoveToTopTap_" 247 on-tap="onMoveToTopTap_"
248 hidden="[[isFirstLanguage_( 248 hidden="[[isNthLanguage_(
249 detailLanguage_, languages.enabled.*)]]"> 249 0, detailLanguage_, languages.enabled.*)]]">
250 $i18n{moveToTop} 250 $i18n{moveToTop}
251 </button> 251 </button>
252 <button class="dropdown-item" role="menuitem" 252 <button class="dropdown-item" role="menuitem"
253 on-tap="onMoveUpTap_" 253 on-tap="onMoveUpTap_"
254 hidden="[[isFirstOrSecondLanguage_( 254 hidden="[[!showMoveUp_(detailLanguage_, languages.enabled.*)]]">
255 detailLanguage_, languages.enabled.*)]]">
256 $i18n{moveUp} 255 $i18n{moveUp}
257 </button> 256 </button>
258 <button class="dropdown-item" role="menuitem" 257 <button class="dropdown-item" role="menuitem"
259 on-tap="onMoveDownTap_" 258 on-tap="onMoveDownTap_"
260 hidden="[[isLastLanguage_( 259 hidden="[[!showMoveDown_(
261 detailLanguage_, languages.enabled.*)]]"> 260 detailLanguage_, languages.enabled.*)]]">
262 $i18n{moveDown} 261 $i18n{moveDown}
263 </button> 262 </button>
264 <button class="dropdown-item" role="menuitem" 263 <button class="dropdown-item" role="menuitem"
265 on-tap="onRemoveLanguageTap_" 264 on-tap="onRemoveLanguageTap_"
266 hidden="[[!detailLanguage_.removable]]"> 265 hidden="[[!detailLanguage_.removable]]">
267 $i18n{removeLanguage} 266 $i18n{removeLanguage}
268 </button> 267 </button>
269 </dialog> 268 </dialog>
270 </template> 269 </template>
(...skipping 20 matching lines...) Expand all
291 </if> 290 </if>
292 </settings-animated-pages> 291 </settings-animated-pages>
293 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp> 292 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp>
294 <settings-add-languages-dialog languages="{{languages}}" 293 <settings-add-languages-dialog languages="{{languages}}"
295 language-helper="[[languageHelper]]"> 294 language-helper="[[languageHelper]]">
296 </settings-add-languages-dialog> 295 </settings-add-languages-dialog>
297 </template> 296 </template>
298 </template> 297 </template>
299 <script src="languages_page.js"></script> 298 <script src="languages_page.js"></script>
300 </dom-module> 299 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698