chrome/browser/resources/settings/languages_page/languages_page.html - Issue 2675453002: Language settings: Fix unnecessarily shown move buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2675453002: Language settings: Fix unnecessarily shown move buttons (Closed)

Patch Set: prettier test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/languages_page/languages_page.js » ('j') | chrome/browser/resources/settings/languages_page/languages_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/languages_page/languages_page.html

diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html

index 9a9d6469675f641e534ccef299a639216c9bb865..4f9b67b2c8342375a7e38e18adac14246ede5367 100644

--- a/chrome/browser/resources/settings/languages_page/languages_page.html

+++ b/chrome/browser/resources/settings/languages_page/languages_page.html

@@ -239,19 +239,18 @@

<hr>

<button class="dropdown-item" role="menuitem"

on-tap="onMoveToTopTap_"

- hidden="[[isFirstLanguage_(

- detailLanguage_, languages.enabled.*)]]">

+ hidden="[[isNthLanguage_(

+ 0, detailLanguage_, languages.enabled.*)]]">

$i18n{moveToTop}

</button>

<button class="dropdown-item" role="menuitem"

on-tap="onMoveUpTap_"

- hidden="[[isFirstOrSecondLanguage_(

- detailLanguage_, languages.enabled.*)]]">

+ hidden="[[!showMoveUp_(detailLanguage_, languages.enabled.*)]]">

$i18n{moveUp}

</button>

<button class="dropdown-item" role="menuitem"

on-tap="onMoveDownTap_"

- hidden="[[isLastLanguage_(

+ hidden="[[!showMoveDown_(

detailLanguage_, languages.enabled.*)]]">

$i18n{moveDown}

</button>