Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Side by Side Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2675453002: Language settings: Fix unnecessarily shown move buttons (Closed)
Patch Set: prettier test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/action_link.html"> 1 <link rel="import" href="chrome://resources/html/action_link.html">
2 <link rel="import" href="chrome://resources/html/action_link_css.html"> 2 <link rel="import" href="chrome://resources/html/action_link_css.html">
3 <link rel="import" href="chrome://resources/html/assert.html"> 3 <link rel="import" href="chrome://resources/html/assert.html">
4 <link rel="import" href="chrome://resources/html/cr.html"> 4 <link rel="import" href="chrome://resources/html/cr.html">
5 <link rel="import" href="chrome://resources/html/polymer.html"> 5 <link rel="import" href="chrome://resources/html/polymer.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-ani matable.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
10 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html"> 10 <link rel="import" href="chrome://resources/cr_elements/cr_action_menu/cr_action _menu.html">
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 checked="[[detailLanguage_.translateEnabled]]" 232 checked="[[detailLanguage_.translateEnabled]]"
233 on-change="onTranslateCheckboxChange_" 233 on-change="onTranslateCheckboxChange_"
234 hidden="[[!prefs.translate.enabled.value]]" 234 hidden="[[!prefs.translate.enabled.value]]"
235 disabled="[[disableTranslateCheckbox_( 235 disabled="[[disableTranslateCheckbox_(
236 detailLanguage_.language, languages.translateTarget)]]"> 236 detailLanguage_.language, languages.translateTarget)]]">
237 $i18n{offerToTranslateInThisLanguage} 237 $i18n{offerToTranslateInThisLanguage}
238 </paper-checkbox> 238 </paper-checkbox>
239 <hr> 239 <hr>
240 <button class="dropdown-item" role="menuitem" 240 <button class="dropdown-item" role="menuitem"
241 on-tap="onMoveToTopTap_" 241 on-tap="onMoveToTopTap_"
242 hidden="[[isFirstLanguage_( 242 hidden="[[isNthLanguage_(
243 detailLanguage_, languages.enabled.*)]]"> 243 0, detailLanguage_, languages.enabled.*)]]">
244 $i18n{moveToTop} 244 $i18n{moveToTop}
245 </button> 245 </button>
246 <button class="dropdown-item" role="menuitem" 246 <button class="dropdown-item" role="menuitem"
247 on-tap="onMoveUpTap_" 247 on-tap="onMoveUpTap_"
248 hidden="[[isFirstOrSecondLanguage_( 248 hidden="[[!showMoveUp_(detailLanguage_, languages.enabled.*)]]">
249 detailLanguage_, languages.enabled.*)]]">
250 $i18n{moveUp} 249 $i18n{moveUp}
251 </button> 250 </button>
252 <button class="dropdown-item" role="menuitem" 251 <button class="dropdown-item" role="menuitem"
253 on-tap="onMoveDownTap_" 252 on-tap="onMoveDownTap_"
254 hidden="[[isLastLanguage_( 253 hidden="[[!showMoveDown_(
255 detailLanguage_, languages.enabled.*)]]"> 254 detailLanguage_, languages.enabled.*)]]">
256 $i18n{moveDown} 255 $i18n{moveDown}
257 </button> 256 </button>
258 <button class="dropdown-item" role="menuitem" 257 <button class="dropdown-item" role="menuitem"
259 on-tap="onRemoveLanguageTap_" 258 on-tap="onRemoveLanguageTap_"
260 hidden="[[!detailLanguage_.removable]]"> 259 hidden="[[!detailLanguage_.removable]]">
261 $i18n{removeLanguage} 260 $i18n{removeLanguage}
262 </button> 261 </button>
263 </dialog> 262 </dialog>
264 </template> 263 </template>
(...skipping 20 matching lines...) Expand all
285 </if> 284 </if>
286 </settings-animated-pages> 285 </settings-animated-pages>
287 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp> 286 <template is="dom-if" if="[[showAddLanguagesDialog_]]" restamp>
288 <settings-add-languages-dialog languages="{{languages}}" 287 <settings-add-languages-dialog languages="{{languages}}"
289 language-helper="[[languageHelper]]"> 288 language-helper="[[languageHelper]]">
290 </settings-add-languages-dialog> 289 </settings-add-languages-dialog>
291 </template> 290 </template>
292 </template> 291 </template>
293 <script src="languages_page.js"></script> 292 <script src="languages_page.js"></script>
294 </dom-module> 293 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698