MD Settings: CrOS: Elim device page icons

MD Settings: CrOS: Elim device page icons

BUG=689150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2675383003
Cr-Commit-Position: refs/heads/master@{#449092}
Committed: https://chromium.googlesource.com/chromium/src/+/c5f01710700ab9ee7194bdb00699f00afce9775d

[stevenjb, 2017-02-07 01:47:38]

Description was changed from

==========
MD Settings: CrOS: Elim device page icons

BUG=698150
==========

to

==========
MD Settings: CrOS: Elim device page icons

BUG=698150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[stevenjb, 2017-02-07 01:51:55]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[stevenjb, 2017-02-07 01:51:56]

This CL makes me kind of sad, bug UX has decreed.

[Dan Beam, 2017-02-07 03:10:52]

Description was changed from

==========
MD Settings: CrOS: Elim device page icons

BUG=698150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: CrOS: Elim device page icons

BUG=689150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2017-02-08 00:00:07]

/cc derat who might end up adding the battery icon back when creating the Power
subpage.

lgtm.

[stevenjb, 2017-02-08 00:07:20]

On 2017/02/08 00:00:07, michaelpg wrote:
> /cc derat who might end up adding the battery icon back when creating the
Power
> subpage.
> 
> lgtm.

Yeah, we can always restore the logic from git history.

[stevenjb, 2017-02-08 00:07:24]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:07:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 02:18:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 02:18:12]

Failed to apply patch for
chrome/browser/resources/settings/device_page/device_page.html:
While running git apply --index -p1;
  error: patch failed:
chrome/browser/resources/settings/device_page/device_page.html:34
  error: chrome/browser/resources/settings/device_page/device_page.html: patch
does not apply

Patch:       chrome/browser/resources/settings/device_page/device_page.html
Index: chrome/browser/resources/settings/device_page/device_page.html
diff --git a/chrome/browser/resources/settings/device_page/device_page.html
b/chrome/browser/resources/settings/device_page/device_page.html
index
e50598a7eecbdb9f4c45d2cf04af28595b168d99..36a61752a4172077aaf277a8f528793ff53d8f14
100644
--- a/chrome/browser/resources/settings/device_page/device_page.html
+++ b/chrome/browser/resources/settings/device_page/device_page.html
@@ -2,7 +2,6 @@
 <link rel="import" href="chrome://resources/html/md_select_css.html">
 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import"
href="chrome://resources/html/web_ui_listener_behavior.html">
-<link rel="import"
href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
 <link rel="import"
href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
 <link rel="import"
href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button-light.html">
 <link rel="import" href="device_page_browser_proxy.html">
@@ -11,7 +10,6 @@
 <link rel="import" href="pointers.html">
 <link rel="import" href="storage.html">
 <link rel="import" href="stylus.html">
-<link rel="import" href="../icons.html">
 <link rel="import" href="../prefs/prefs.html">
 <link rel="import" href="../route.html">
 <link rel="import" href="../settings_page/settings_animated_pages.html">
@@ -25,8 +23,6 @@
       <neon-animatable id="main" route-path="default">
         <div id="pointersRow" class="settings-box first"
             on-tap="onPointersTap_" actionable>
-          <iron-icon icon="[[getPointersIcon_(hasMouse_, hasTouchpad_)]]">
-          </iron-icon>
           <div class="middle">
             [[getPointersTitle_(hasMouse_, hasTouchpad_)]]
           </div>
@@ -34,33 +30,28 @@
         </div>
         <div id="keyboardRow" class="settings-box" on-tap="onKeyboardTap_"
             actionable>
-          <iron-icon icon="settings:keyboard"></iron-icon>
           <div class="middle">$i18n{keyboardTitle}</div>
           <button class="subpage-arrow" is="paper-icon-button-light"></button>
         </div>
         <template is="dom-if" if="[[stylusAllowed_]]">
           <div id="stylusRow" class="settings-box" on-tap="onStylusTap_"
               actionable>
-            <iron-icon icon="settings:note"></iron-icon>
             <div class="middle">$i18n{stylusTitle}</div>
           <button class="subpage-arrow" is="paper-icon-button-light"></button>
           </div>
         </template>
         <div id="displayRow" class="settings-box" on-tap="onDisplayTap_"
             actionable>
-          <iron-icon icon="settings:desktop-windows"></iron-icon>
           <div class="middle">$i18n{displayTitle}</div>
           <button class="subpage-arrow" is="paper-icon-button-light"></button>
         </div>
         <div id="storageRow" class="settings-box" on-tap="onStorageTap_"
             actionable>
-          <iron-icon icon="settings:storage"></iron-icon>
           <div class="middle">$i18n{storageTitle}</div>
           <button class="subpage-arrow" is="paper-icon-button-light"></button>
         </div>
         <template is="dom-if" if="[[enablePowerSettings_]]">
           <div id="powerRow" class="settings-box two-line">
-            <iron-icon icon="[[batteryIcon_]]"></iron-icon>
             <div class="middle">
               <div>[[powerLabel_]]</div>
               <div class="secondary">[[batteryStatus_.statusText]]</div>

[stevenjb, 2017-02-08 19:24:59]

The CQ bit was checked by stevenjb@chromium.org

[stevenjb, 2017-02-08 19:24:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2675383003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-08 19:25:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 21:16:18]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486581899379670,
"parent_rev": "0766bcb584f9dc069573be95e06e019b37d280e0", "commit_rev":
"c5f01710700ab9ee7194bdb00699f00afce9775d"}

[commit-bot: I haz the power, 2017-02-08 21:16:54]

Description was changed from

==========
MD Settings: CrOS: Elim device page icons

BUG=689150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: CrOS: Elim device page icons

BUG=689150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2675383003
Cr-Commit-Position: refs/heads/master@{#449092}
Committed:
https://chromium.googlesource.com/chromium/src/+/c5f01710700ab9ee7194bdb00699...
==========

[commit-bot: I haz the power, 2017-02-08 21:16:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c5f01710700ab9ee7194bdb00699...