Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Issue 2675363003: [InputEvent] Fire "insertCompositionText" during IME (Closed)

Created:
3 years, 10 months ago by chongz
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9, ojan
CC:
blink-reviews, chaopeng, chromium-reviews, dtapuska
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[InputEvent] Fire "insertCompositionText" during IME According to the latest discussion we only fire non-cancelable "insertCompositionText" during IME. Event Order: 1. compositionstart (2. beforeinput "insertCompositionText" 3. compositionupdate 4.)+ input "insertCompositionText" 5. compositionupdate 2-4 could repeat multiple times. The approach is to fire "insertCompositionText" along with "compositionupdate". Proposal: https://lists.w3.org/Archives/Public/public-editing-tf/2017Feb/0003.html BUG=689541 Review-Url: https://codereview.chromium.org/2675363003 Cr-Commit-Position: refs/heads/master@{#450095} Committed: https://chromium.googlesource.com/chromium/src/+/1e17147805b80e1953b51b0ec29cf26798c09b13

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -51 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 4 chunks +10 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/InputEvent.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
chongz
yosin@ PTAL, thanks!
3 years, 10 months ago (2017-02-07 01:55:47 UTC) #7
yosin_UTC9
lgtm Thanks for quick work! (^_^)b
3 years, 10 months ago (2017-02-07 06:51:27 UTC) #8
chongz
ojan@ PTAL, thanks!
3 years, 10 months ago (2017-02-07 15:24:45 UTC) #13
chongz
On 2017/02/07 15:24:45, chongz wrote: > ojan@ PTAL, thanks! ojan@ PTAL, thanks!
3 years, 10 months ago (2017-02-13 19:00:15 UTC) #14
ojan
lgtm
3 years, 10 months ago (2017-02-13 19:35:55 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675363003/1
3 years, 10 months ago (2017-02-13 19:36:39 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 21:26:37 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1e17147805b80e1953b51b0ec29c...

Powered by Google App Engine
This is Rietveld 408576698