Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: net/spdy/spdy_test_utils.h

Issue 2675343002: Server push cancellation: add NetLogs to track cache lookup transaction (Closed)
Patch Set: address eroman's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_test_utils.h
diff --git a/net/spdy/spdy_test_utils.h b/net/spdy/spdy_test_utils.h
index eb27d66f4eeefe0f9e282e47bf7a1b5ec3b2e2ea..1fcf05e92fdeea4ab81bbd9000643f00586f4731 100644
--- a/net/spdy/spdy_test_utils.h
+++ b/net/spdy/spdy_test_utils.h
@@ -93,7 +93,8 @@ class TestServerPushDelegate : public ServerPushDelegate {
explicit TestServerPushDelegate();
~TestServerPushDelegate() override;
- void OnPush(std::unique_ptr<ServerPushHelper> push_helper) override;
+ void OnPush(std::unique_ptr<ServerPushHelper> push_helper,
+ const NetLogWithSource& source) override;
eroman 2017/02/10 23:57:47 Consistency: in the other implementation overrides
Zhongyi Shi 2017/02/11 02:21:11 Done.
bool CancelPush(GURL url);

Powered by Google App Engine
This is Rietveld 408576698