Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1097)

Unified Diff: net/spdy/server_push_delegate.h

Issue 2675343002: Server push cancellation: add NetLogs to track cache lookup transaction (Closed)
Patch Set: address eroman's comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/server_push_delegate.h
diff --git a/net/spdy/server_push_delegate.h b/net/spdy/server_push_delegate.h
index 7e9c3db84ed43824114a1206544d549f133d2227..0e6b365107747d53147b95da1f222972b0e0419b 100644
--- a/net/spdy/server_push_delegate.h
+++ b/net/spdy/server_push_delegate.h
@@ -6,6 +6,7 @@
#define NET_SPDY_SERVER_PUSH_DELEGATE_H_
#include "net/base/net_export.h"
+#include "net/log/net_log_with_source.h"
#include "url/gurl.h"
namespace net {
@@ -23,13 +24,15 @@ class NET_EXPORT_PRIVATE ServerPushDelegate {
virtual void Cancel() = 0;
// Gets the URL of the pushed request.
- virtual const GURL& GetURL() = 0;
+ virtual const GURL& GetURL() const = 0;
};
virtual ~ServerPushDelegate() {}
// Invoked by session when a push promise has been received.
- virtual void OnPush(std::unique_ptr<ServerPushHelper> push_helper) = 0;
+ // |source_net_log| is owned by the caller of this method.
eroman 2017/02/10 23:57:47 Same comment as earlier regarding comment + parame
Zhongyi Shi 2017/02/11 02:21:11 Done.
+ virtual void OnPush(std::unique_ptr<ServerPushHelper> push_helper,
+ const NetLogWithSource& source_net_log) = 0;
};
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698