Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2675303004: Move WebCache from public/web into public/platform (Closed)

Created:
3 years, 10 months ago by kinuko
Modified:
3 years, 10 months ago
CC:
android-webview-reviews_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blundell+watchlist_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, droger+watchlist_chromium.org, einbinder+watch-test-runner_chromium.org, extensions-reviews_chromium.org, gavinp+prerender_chromium.org, jam, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, sdefresne+watchlist_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move WebCache from public/web into public/platform Now that MemoryCache related files moved into platform/, this doesn't really need to live in public/web either. BUG=689341 TBR=boliu@chromioum.org Review-Url: https://codereview.chromium.org/2675303004 Cr-Commit-Position: refs/heads/master@{#448937} Committed: https://chromium.googlesource.com/chromium/src/+/ed1ed1d44cdeff32f6fd210b9e72864c60402426

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -229 lines) Patch
M android_webview/renderer/aw_render_thread_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/processes/processes_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/process_resource_usage.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/providers/task.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/task_manager/task_manager_table_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/resource_usage_reporter_type_converters.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_render_thread_observer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/net_benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/test_interfaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_cache/renderer/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/web_cache/renderer/web_cache_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/test/blink_test_environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/exported/WebCache.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImplTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebAssociatedURLLoaderImplTest.cpp View 1 3 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/web/WebCache.cpp View 1 chunk +0 lines, -83 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ActivityLoggerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/BrowserControlsTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/DocumentLoaderTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/FrameSerializerTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ImeOnFocusTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/LayoutGeometryMapTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ListenerLeakTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/MHTMLTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/PrerenderingTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ProgrammaticScrollTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/RootScrollerTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ScreenWakeLockTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/TouchActionTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ViewportTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebDocumentSubresourceFilterTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameSerializerTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebSearchableFormDataTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 4 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
A + third_party/WebKit/public/platform/WebCache.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
D third_party/WebKit/public/web/WebCache.h View 1 chunk +0 lines, -83 lines 0 comments Download

Messages

Total messages: 47 (37 generated)
kinuko
I think we can move this file too-- PTL
3 years, 10 months ago (2017-02-07 13:05:01 UTC) #31
Takashi Toyoshima
LGTM
3 years, 10 months ago (2017-02-07 13:15:49 UTC) #32
Nate Chapin
No objections - LGTM
3 years, 10 months ago (2017-02-07 22:01:26 UTC) #33
kinuko
jochen@: can you do uber owner review for chrome & components?
3 years, 10 months ago (2017-02-07 22:41:40 UTC) #35
kinuko
On 2017/02/07 22:41:40, kinuko wrote: > jochen@: can you do uber owner review for chrome ...
3 years, 10 months ago (2017-02-08 07:01:59 UTC) #38
dcheng
rs lgtm for mojo change
3 years, 10 months ago (2017-02-08 08:05:16 UTC) #39
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-08 09:02:22 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675303004/100001
3 years, 10 months ago (2017-02-08 09:08:34 UTC) #43
commit-bot: I haz the power
Committed patchset #3 (id:100001) as https://chromium.googlesource.com/chromium/src/+/ed1ed1d44cdeff32f6fd210b9e72864c60402426
3 years, 10 months ago (2017-02-08 09:14:25 UTC) #46
boliu
3 years, 10 months ago (2017-02-08 14:13:48 UTC) #47
Message was sent while issue was closed.
On 2017/02/08 07:01:59, kinuko wrote:
> On 2017/02/07 22:41:40, kinuko wrote:
> > jochen@: can you do uber owner review for chrome & components?
> 
> boliu@: could you review android_webview changes? (header location change
only,
> will TBR)

lgtm

> 
> dcheng@: could you review resource_usage_reporter_type_converters.h change?
> (header location change only, will TBR)

Powered by Google App Engine
This is Rietveld 408576698