Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2675263002: [Test] Update 'default' SixSpeed benchmark to use different processes. (Closed)

Created:
3 years, 10 months ago by petermarshall
Modified:
3 years, 10 months ago
Reviewers:
Franzi, Michael Hablich
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Test] Update 'default' SixSpeed benchmark to use different processes. The results are unreliable as-is, because es5 and es6 run in the same d8 process consecutively. The graph also shows a huge amount of noise, which seems to be mostly resolved with this change. Review-Url: https://codereview.chromium.org/2675263002 Cr-Commit-Position: refs/heads/master@{#42961} Committed: https://chromium.googlesource.com/v8/v8/+/54a14005fdc13009565488ca28a9668bf5a79c04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -80 lines) Patch
M test/js-perf-test/SixSpeed.json View 1 chunk +11 lines, -8 lines 0 comments Download
D test/js-perf-test/SixSpeed/defaults/defaults.js View 1 chunk +0 lines, -47 lines 0 comments Download
A test/js-perf-test/SixSpeed/defaults/es5.js View 1 chunk +23 lines, -0 lines 0 comments Download
A test/js-perf-test/SixSpeed/defaults/es6.js View 1 chunk +21 lines, -0 lines 0 comments Download
D test/js-perf-test/SixSpeed/defaults/run.js View 1 chunk +0 lines, -25 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
petermarshall
PTAL =]
3 years, 10 months ago (2017-02-06 10:45:05 UTC) #2
Michael Hablich
On 2017/02/06 10:45:05, petermarshall wrote: > PTAL =] Thanks, lgtm.
3 years, 10 months ago (2017-02-06 10:46:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675263002/1
3 years, 10 months ago (2017-02-06 11:31:19 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 11:51:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/54a14005fdc13009565488ca28a9668bf5a...

Powered by Google App Engine
This is Rietveld 408576698