Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2675243003: [ObjC ARC] Converts ios/chrome/browser/ui/authentication:unit_tests to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
Reviewers:
stkhapugin, bzanotti
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/authentication:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2675243003 Cr-Commit-Position: refs/heads/master@{#448575} Committed: https://chromium.googlesource.com/chromium/src/+/09946a97b3d028d3f897d4fc113a0045c2cdf964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -35 lines) Patch
M ios/chrome/browser/ui/authentication/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/authentication/authentication_flow_unittest.mm View 7 chunks +23 lines, -23 lines 0 comments Download
M ios/chrome/browser/ui/authentication/re_signin_infobar_delegate_unittest.mm View 5 chunks +11 lines, -12 lines 0 comments Download
M ios/chrome/browser/ui/authentication/signed_in_accounts_view_controller_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
lody
More arc conversions to review! Yaaay! 🎉
3 years, 10 months ago (2017-02-06 17:37:11 UTC) #4
stkhapugin
lgtm
3 years, 10 months ago (2017-02-06 18:03:48 UTC) #7
bzanotti
lgtm
3 years, 10 months ago (2017-02-06 18:17:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675243003/1
3 years, 10 months ago (2017-02-07 09:17:50 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 09:22:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/09946a97b3d028d3f897d4fc113a...

Powered by Google App Engine
This is Rietveld 408576698