Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2675233003: Replace OnMemoryStateChange() with OnPurgeMemory() in RendererFrameManager (Closed)

Created:
3 years, 10 months ago by bashi
Modified:
3 years, 10 months ago
Reviewers:
haraken, kinuko, tasak
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace OnMemoryStateChange() with OnPurgeMemory() in RendererFrameManager We added OnPurgeMemory() callback to MemoryCoordinatorClient so that we can separate memory purging from memory state transition (See [1] for the motivation of this separation). This CL replaces OnMemoryStateChange() with OnPurgeMemory() in RendererFrameManager because it just purges memory. [1] https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/project-trim/s96xSirL2Hs/18uq1zfHEgAJ BUG=684287 Review-Url: https://codereview.chromium.org/2675233003 Cr-Commit-Position: refs/heads/master@{#448544} Committed: https://chromium.googlesource.com/chromium/src/+/f9da465ceffbabd47592b4142b4a4d293db7d685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -16 lines) Patch
M content/browser/renderer_host/renderer_frame_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/renderer_frame_manager.cc View 1 chunk +2 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
bashi
PTAL
3 years, 10 months ago (2017-02-07 02:39:08 UTC) #6
tasak
lgtm
3 years, 10 months ago (2017-02-07 02:40:28 UTC) #7
bashi
+kinuko@ for OWNERS review
3 years, 10 months ago (2017-02-07 02:43:23 UTC) #9
haraken
LGTM
3 years, 10 months ago (2017-02-07 02:46:51 UTC) #10
kinuko
lgtm
3 years, 10 months ago (2017-02-07 03:51:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675233003/1
3 years, 10 months ago (2017-02-07 04:32:15 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 04:38:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9da465ceffbabd47592b4142b4a...

Powered by Google App Engine
This is Rietveld 408576698