Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2675233002: [iwyu] runtime.h doesn't need objects.h (Closed)

Created:
3 years, 10 months ago by marja
Modified:
3 years, 10 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[iwyu] runtime.h doesn't need objects.h BUG=v8:5294 R=mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2675233002 Cr-Commit-Position: refs/heads/master@{#42963} Committed: https://chromium.googlesource.com/v8/v8/+/35a82866d7db157013dd81c3b30134ae0148cc98

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -14 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -13 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
marja
ptal
3 years, 10 months ago (2017-02-06 10:31:43 UTC) #3
Michael Starzinger
LGTM.
3 years, 10 months ago (2017-02-06 11:40:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675233002/20001
3 years, 10 months ago (2017-02-06 11:56:48 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 12:26:37 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/35a82866d7db157013dd81c3b30134ae014...

Powered by Google App Engine
This is Rietveld 408576698