Clear pending message during Isolate::CancelScheduledExceptionFromTryCatch.

Clear pending message during Isolate::CancelScheduledExceptionFromTryCatch.

Without doing this, a JSMessageObject can be kept alive by the isolate, which
in turn keeps the context alive, until the message is cleared.

BUG=v8:5941
Review-Url: https://codereview.chromium.org/2675203005
Cr-Commit-Position: refs/heads/master@{#43043}
Committed: https://chromium.googlesource.com/v8/v8/+/c8910f35399deb00ab9c44e422265da9baabbaec

[jbroman, 2017-02-06 21:04:52]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 21:04:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 21:19:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 21:19:45]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[jbroman, 2017-02-06 21:46:33]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 21:49:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-02-06 21:57:54]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 21:58:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-02-06 22:02:50]

Description was changed from

==========
Clear pending message during Isolate::ScheduleThrow.

BUG=
==========

to

==========
Clear pending message during Isolate::CancelScheduledExceptionFromTryCatch.

Without doing this, a JSMessageObject can be kept alive by the isolate, which
in turn keeps the context alive, until the message is cleared.

BUG=
==========

[commit-bot: I haz the power, 2017-02-06 22:24:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 22:24:14]

Dry run: This issue passed the CQ dry run.

[jbroman, 2017-02-07 16:15:11]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 16:15:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2017-02-07 16:24:41]

Description was changed from

==========
Clear pending message during Isolate::CancelScheduledExceptionFromTryCatch.

Without doing this, a JSMessageObject can be kept alive by the isolate, which
in turn keeps the context alive, until the message is cleared.

BUG=
==========

to

==========
Clear pending message during Isolate::CancelScheduledExceptionFromTryCatch.

Without doing this, a JSMessageObject can be kept alive by the isolate, which
in turn keeps the context alive, until the message is cleared.

BUG=v8:5941
==========

[commit-bot: I haz the power, 2017-02-07 16:37:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 16:37:25]

Dry run: This issue passed the CQ dry run.

[jbroman, 2017-02-07 16:42:31]

jbroman@chromium.org changed reviewers:
+ cbruni@chromium.org

[jbroman, 2017-02-07 16:42:32]

I'm not certain this is the correct fix, but it seems reasonable to me. Please
do take a close look.

Devlin and I ran into an issue like this writing an extension binding test that
ensures that the context isn't leaked. To me, the usage in the test looks
entirely straightforward and it's reasonable to expect that the context is not
kept alive.

[Camillo Bruni, 2017-02-08 07:44:52]

cbruni@chromium.org changed reviewers:
+ yangguo@chromium.org

[Camillo Bruni, 2017-02-08 07:44:53]

Seems reasonable to me, InvokeScope uses the same pattern.

Yang, could you have a quick look?

[Yang, 2017-02-08 08:12:43]

On 2017/02/08 07:44:53, Camillo Bruni wrote:
> Seems reasonable to me, InvokeScope uses the same pattern.
> 
> Yang, could you have a quick look?

lgtm.

[Camillo Bruni, 2017-02-08 08:18:47]

lgtm

[jbroman, 2017-02-08 13:15:28]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-02-08 13:15:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 13:17:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 13:17:50]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/34275)

[jbroman, 2017-02-08 15:48:15]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2017-02-08 15:48:15]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org,
yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2675203005/#ps80001
(title: "Merge branch 'master' into schedule-clear-pending-message")

[commit-bot: I haz the power, 2017-02-08 15:48:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 16:12:59]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486568895071150,
"parent_rev": "bcfcea1c76e880d3a9db7c4998533354a9e9c2da", "commit_rev":
"c8910f35399deb00ab9c44e422265da9baabbaec"}

[commit-bot: I haz the power, 2017-02-08 16:13:04]

Description was changed from

==========
Clear pending message during Isolate::CancelScheduledExceptionFromTryCatch.

Without doing this, a JSMessageObject can be kept alive by the isolate, which
in turn keeps the context alive, until the message is cleared.

BUG=v8:5941
==========

to

==========
Clear pending message during Isolate::CancelScheduledExceptionFromTryCatch.

Without doing this, a JSMessageObject can be kept alive by the isolate, which
in turn keeps the context alive, until the message is cleared.

BUG=v8:5941

Review-Url: https://codereview.chromium.org/2675203005
Cr-Commit-Position: refs/heads/master@{#43043}
Committed:
https://chromium.googlesource.com/v8/v8/+/c8910f35399deb00ab9c44e422265da9baa...
==========

[commit-bot: I haz the power, 2017-02-08 16:13:05]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/c8910f35399deb00ab9c44e422265da9baa...