Remove rejected promise of PiexLoader which is not caught.

Remove rejected promise of PiexLoader which is not caught.

Previously if PiexLoader was not enabled for the build,
PiexLoader.naclPromise_ was rejected and the rejected promise
automatically appeared in console.log.

The CL fulfills a boolean value to naclPromise_ instead of
fullfills/rejects it to reducy noisy uncaught promise logs.

Bug=689264
Test=Manually run Files app with disabling Piex and checked the console.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2675193005
Cr-Commit-Position: refs/heads/master@{#449204}
Committed: https://chromium.googlesource.com/chromium/src/+/6423d6b3eea01831f79139b2d9408dc565a45077

[hirono, 2017-02-07 02:31:08]

Description was changed from

==========
Remove rejected promise of PiexLoader which is not caught.

Previously if PiexLoader was not enabled for the build,
PiexLoader.naclPromise_ was rejected and the rejected promise
automatically appeared in console.log.

The CL fulfills a boolean value to naclPromise_ instead of
fullfills/rejects it to reducy noisy uncaught promise logs.

Bug=689264
Test=Manually run Files app with disabling Piex and checked the console.
==========

to

==========
Remove rejected promise of PiexLoader which is not caught.

Previously if PiexLoader was not enabled for the build,
PiexLoader.naclPromise_ was rejected and the rejected promise
automatically appeared in console.log.

The CL fulfills a boolean value to naclPromise_ instead of
fullfills/rejects it to reducy noisy uncaught promise logs.

Bug=689264
Test=Manually run Files app with disabling Piex and checked the console.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[hirono, 2017-02-07 02:32:46]

hirono@chromium.org changed reviewers:
+ oka@chromium.org

[hirono, 2017-02-07 02:32:46]

PTAL, thank you!

[hirono, 2017-02-07 02:33:00]

The CQ bit was checked by hirono@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 02:33:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 03:57:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 03:57:06]

Dry run: This issue passed the CQ dry run.

[oka, 2017-02-07 17:01:33]

lgtm

LGTM with nit. Thank you for fixing this.

https://codereview.chromium.org/2675193005/diff/1/ui/file_manager/image_loade...
File ui/file_manager/image_loader/piex_loader.js (right):

https://codereview.chromium.org/2675193005/diff/1/ui/file_manager/image_loade...
ui/file_manager/image_loader/piex_loader.js:102: return true;
wondering why it's not fulfill(true).

[hirono, 2017-02-09 03:52:55]

Thanks!

https://codereview.chromium.org/2675193005/diff/1/ui/file_manager/image_loade...
File ui/file_manager/image_loader/piex_loader.js (right):

https://codereview.chromium.org/2675193005/diff/1/ui/file_manager/image_loade...
ui/file_manager/image_loader/piex_loader.js:102: return true;
On 2017/02/07 17:01:33, oka wrote:
> wondering why it's not fulfill(true).

Yes, the line is wrong. Removed this and updated #91. Thanks!

[hirono, 2017-02-09 03:53:10]

The CQ bit was checked by hirono@chromium.org

[hirono, 2017-02-09 03:53:10]

The patchset sent to the CQ was uploaded after l-g-t-m from oka@chromium.org
Link to the patchset: https://codereview.chromium.org/2675193005/#ps20001
(title: ".")

[commit-bot: I haz the power, 2017-02-09 03:54:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 05:04:34]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486612390211080,
"parent_rev": "2254cd2051623bbe445fd16da8aabcb16d37b0f4", "commit_rev":
"6423d6b3eea01831f79139b2d9408dc565a45077"}

[commit-bot: I haz the power, 2017-02-09 05:05:47]

Description was changed from

==========
Remove rejected promise of PiexLoader which is not caught.

Previously if PiexLoader was not enabled for the build,
PiexLoader.naclPromise_ was rejected and the rejected promise
automatically appeared in console.log.

The CL fulfills a boolean value to naclPromise_ instead of
fullfills/rejects it to reducy noisy uncaught promise logs.

Bug=689264
Test=Manually run Files app with disabling Piex and checked the console.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove rejected promise of PiexLoader which is not caught.

Previously if PiexLoader was not enabled for the build,
PiexLoader.naclPromise_ was rejected and the rejected promise
automatically appeared in console.log.

The CL fulfills a boolean value to naclPromise_ instead of
fullfills/rejects it to reducy noisy uncaught promise logs.

Bug=689264
Test=Manually run Files app with disabling Piex and checked the console.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2675193005
Cr-Commit-Position: refs/heads/master@{#449204}
Committed:
https://chromium.googlesource.com/chromium/src/+/6423d6b3eea01831f79139b2d940...
==========

[commit-bot: I haz the power, 2017-02-09 05:05:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6423d6b3eea01831f79139b2d940...