Add gpu_main_thread_factory.h to expose less of content's guts.

Add gpu_main_thread_factory.h to expose less of content's guts.

gpu_process_host.h exposes a lot of the content layer's guts, including
mojo message files which complicate build depenencies.

Add gpu_main_thread_factory.h to expose the bits that things outside of
content/browser are using. Sepcifically, RegisterGpuMainThreadFactory().

After this, the only files that #include gpu_process_host.h are .cc
files in content/browser or content/public/browser. That is, files built
in a target that already has a dependency on the source of build flakes
coming from //services/ui/gpu/interfaces/.

BUG=688477
TBR=avi@chromium.org

Review-Url: https://codereview.chromium.org/2675163002
Cr-Commit-Position: refs/heads/master@{#448472}
Committed: https://chromium.googlesource.com/chromium/src/+/4091f2f04a14767d816857bd480088c3c62d25d8

[tapted, 2017-02-06 02:25:47]

Description was changed from

==========
Add gpu_main_thread_factory.h to expose less of content's guts.

gpu_process_host.h exposes a lot of the content layer's guts, including
mojo message files which complicate build depenencies.

Add gpu_main_thread_factory.h to expose the bits that things outside of
content/browser are using. Sepcifically, RegisterGpuMainThreadFactory().

After this, the only files that #include gpu_process_host.h are .cc files
in content/browser or content/public/browser.

BUG=688477
==========

to

==========
Add gpu_main_thread_factory.h to expose less of content's guts.

gpu_process_host.h exposes a lot of the content layer's guts, including
mojo message files which complicate build depenencies.

Add gpu_main_thread_factory.h to expose the bits that things outside of
content/browser are using. Sepcifically, RegisterGpuMainThreadFactory().

After this, the only files that #include gpu_process_host.h are .cc
files in content/browser or content/public/browser. That is, files build
in a target that already has a dependency on the source of build flakes
coming from //services/ui/gpu/interfaces/.

BUG=688477
==========

[tapted, 2017-02-06 02:27:58]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 02:28:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 02:37:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 02:37:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tapted, 2017-02-06 02:48:47]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 02:48:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-02-06 03:30:27]

Description was changed from

==========
Add gpu_main_thread_factory.h to expose less of content's guts.

gpu_process_host.h exposes a lot of the content layer's guts, including
mojo message files which complicate build depenencies.

Add gpu_main_thread_factory.h to expose the bits that things outside of
content/browser are using. Sepcifically, RegisterGpuMainThreadFactory().

After this, the only files that #include gpu_process_host.h are .cc
files in content/browser or content/public/browser. That is, files build
in a target that already has a dependency on the source of build flakes
coming from //services/ui/gpu/interfaces/.

BUG=688477
==========

to

==========
Add gpu_main_thread_factory.h to expose less of content's guts.

gpu_process_host.h exposes a lot of the content layer's guts, including
mojo message files which complicate build depenencies.

Add gpu_main_thread_factory.h to expose the bits that things outside of
content/browser are using. Sepcifically, RegisterGpuMainThreadFactory().

After this, the only files that #include gpu_process_host.h are .cc
files in content/browser or content/public/browser. That is, files built
in a target that already has a dependency on the source of build flakes
coming from //services/ui/gpu/interfaces/.

BUG=688477
==========

[tapted, 2017-02-06 03:40:30]

tapted@chromium.org changed reviewers:
+ kbr@chromium.org

[tapted, 2017-02-06 03:40:30]

kbr: please take a look.

(cc sadrul fyi or for comments :)

[commit-bot: I haz the power, 2017-02-06 03:47:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 03:47:09]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-02-06 07:27:36]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 07:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 08:13:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 08:13:43]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-02-06 23:46:36]

tapted@chromium.org changed reviewers:
+ avi@chromium.org

[tapted, 2017-02-06 23:46:36]

ping? 

the waterfall just closed because of the issue this CL is trying to fix -
https://build.chromium.org/p/chromium/builders/Win%20x64/builds/8273 - so this
is now Pri-0

+avi since I will need a content owner eventually, but ideally one of the gpu
OWNERS can take a look too. Thanks!

[tapted, 2017-02-06 23:51:42]

tapted@chromium.org changed reviewers:
+ jbauman@chromium.org

[tapted, 2017-02-06 23:52:25]

On 2017/02/06 23:46:36, tapted wrote:
> ping? 
> 
> the waterfall just closed because of the issue this CL is trying to fix -
> https://build.chromium.org/p/chromium/builders/Win%20x64/builds/8273 - so this
> is now Pri-0
> 
> +avi since I will need a content owner eventually, but ideally one of the gpu
> OWNERS can take a look too. Thanks!

+jbauman too (kbr@ may be on vacation? I think piman@ is out too)

[jbauman, 2017-02-07 00:03:54]

lgtm, though I'm curious what fails if you actually add the correct dependency.

[tapted, 2017-02-07 00:19:55]

On 2017/02/07 00:03:54, jbauman wrote:
> lgtm, though I'm curious what fails if you actually add the correct
dependency.

The problem is that the correct dependency won't resolve the build flakes :/. 

i.e. content_main_runner.cc #includes "content/browser/gpu/gpu_process_host.h",
so `content_app_deps` should have //content/browser as a direct dependency
(except that that's not allowed --   "# Only the public target should depend on
[//content/browser]. All other targets (even  # internal content ones) should
depend on the public one.")

But, even if content_app_deps did depend on //content/browser, the build flakes
wouldn't stop, because //content/browser doesn't declare 
"//services/ui/gpu/interfaces" as a public_dep. This means that content_app_deps
would only block its link step on //content/browser's link step, but
content_app_deps actually needs to block its _compile_ step on
//services/ui/gpu/interfaces

(but this is complex! IMO it all kinda boils down to too much guts being exposed
via gpu_process_host.h, so this CL works towards simplifying that)

[tapted, 2017-02-07 00:23:35]

Description was changed from

==========
Add gpu_main_thread_factory.h to expose less of content's guts.

gpu_process_host.h exposes a lot of the content layer's guts, including
mojo message files which complicate build depenencies.

Add gpu_main_thread_factory.h to expose the bits that things outside of
content/browser are using. Sepcifically, RegisterGpuMainThreadFactory().

After this, the only files that #include gpu_process_host.h are .cc
files in content/browser or content/public/browser. That is, files built
in a target that already has a dependency on the source of build flakes
coming from //services/ui/gpu/interfaces/.

BUG=688477
==========

to

==========
Add gpu_main_thread_factory.h to expose less of content's guts.

gpu_process_host.h exposes a lot of the content layer's guts, including
mojo message files which complicate build depenencies.

Add gpu_main_thread_factory.h to expose the bits that things outside of
content/browser are using. Sepcifically, RegisterGpuMainThreadFactory().

After this, the only files that #include gpu_process_host.h are .cc
files in content/browser or content/public/browser. That is, files built
in a target that already has a dependency on the source of build flakes
coming from //services/ui/gpu/interfaces/.

BUG=688477
TBR=avi@chromium.org
==========

[tapted, 2017-02-07 00:25:15]

avi -> to TBR (for content OWNERS - it's just refactoring fallout and build
files. I'd like to monitor this on the waterfall while I'm still build sheriff
:).

[tapted, 2017-02-07 00:25:28]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2017-02-07 00:26:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 00:47:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486427128080460,
"parent_rev": "3db94dc4cd5cc78b799faac1040d843019a9fb9a", "commit_rev":
"4091f2f04a14767d816857bd480088c3c62d25d8"}

[commit-bot: I haz the power, 2017-02-07 00:47:55]

Description was changed from

==========
Add gpu_main_thread_factory.h to expose less of content's guts.

gpu_process_host.h exposes a lot of the content layer's guts, including
mojo message files which complicate build depenencies.

Add gpu_main_thread_factory.h to expose the bits that things outside of
content/browser are using. Sepcifically, RegisterGpuMainThreadFactory().

After this, the only files that #include gpu_process_host.h are .cc
files in content/browser or content/public/browser. That is, files built
in a target that already has a dependency on the source of build flakes
coming from //services/ui/gpu/interfaces/.

BUG=688477
TBR=avi@chromium.org
==========

to

==========
Add gpu_main_thread_factory.h to expose less of content's guts.

gpu_process_host.h exposes a lot of the content layer's guts, including
mojo message files which complicate build depenencies.

Add gpu_main_thread_factory.h to expose the bits that things outside of
content/browser are using. Sepcifically, RegisterGpuMainThreadFactory().

After this, the only files that #include gpu_process_host.h are .cc
files in content/browser or content/public/browser. That is, files built
in a target that already has a dependency on the source of build flakes
coming from //services/ui/gpu/interfaces/.

BUG=688477
TBR=avi@chromium.org

Review-Url: https://codereview.chromium.org/2675163002
Cr-Commit-Position: refs/heads/master@{#448472}
Committed:
https://chromium.googlesource.com/chromium/src/+/4091f2f04a14767d816857bd4800...
==========

[commit-bot: I haz the power, 2017-02-07 00:47:56]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4091f2f04a14767d816857bd4800...

[Avi (use Gerrit), 2017-02-07 03:26:41]

lgtm

stamp

[Ken Russell (switch to Gerrit), 2017-02-08 02:44:41]

Sorry for the long delay getting to this. I defer to jbauman's review.