Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2675153002: Clean up generate_buildbot_json.py. (Closed)

Created:
3 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up generate_buildbot_json.py. Get rid of the fyi_only, run_on_optional, run_on_v8, and allow_on_android flags. Express these in terms of predicates which take into account both the type of the waterfall and the individual bot (or, in the case of Android, disabled_tester_configs). Pure refactoring; JSON files generated by the script are unchanged. BUG=688887 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2675153002 Cr-Commit-Position: refs/heads/master@{#448205} Committed: https://chromium.googlesource.com/chromium/src/+/0a1b40c403c124cd9c0338fb806d442c0e78f143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -149 lines) Patch
M content/test/gpu/generate_buildbot_json.py View 46 chunks +193 lines, -149 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
Ken Russell (switch to Gerrit)
FYI. CQ'ing TBR'd and NOTRY; is a pure refactoring. (Ran the script locally and verified ...
3 years, 10 months ago (2017-02-06 02:27:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675153002/1
3 years, 10 months ago (2017-02-06 02:28:15 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 02:33:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0a1b40c403c124cd9c0338fb806d...

Powered by Google App Engine
This is Rietveld 408576698