Description was changed from ========== Import wpt@97e16bef6d6599ae805521e2007a9430a12aa144 Using wpt-import in Chromium 92dc22973ed15b4e4683d4ac73ea329763f65c25. After skipping hr-time/window-worker-time-origin.html ...
3 years, 10 months ago
(2017-02-06 16:56:42 UTC)
#3
Description was changed from
==========
Import wpt@97e16bef6d6599ae805521e2007a9430a12aa144
Using wpt-import in Chromium 92dc22973ed15b4e4683d4ac73ea329763f65c25.
After skipping hr-time/window-worker-time-origin.html
NOEXPORT=true
==========
to
==========
Import wpt@97e16bef6d6599ae805521e2007a9430a12aa144
Using wpt-import in Chromium 92dc22973ed15b4e4683d4ac73ea329763f65c25.
After skipping hr-time/window-worker-time-origin.html
NOEXPORT=true
BUG=688854
==========
qyearsley
Description was changed from ========== Import wpt@97e16bef6d6599ae805521e2007a9430a12aa144 Using wpt-import in Chromium 92dc22973ed15b4e4683d4ac73ea329763f65c25. After skipping hr-time/window-worker-time-origin.html ...
3 years, 10 months ago
(2017-02-06 16:57:50 UTC)
#4
Description was changed from
==========
Import wpt@97e16bef6d6599ae805521e2007a9430a12aa144
Using wpt-import in Chromium 92dc22973ed15b4e4683d4ac73ea329763f65c25.
After skipping hr-time/window-worker-time-origin.html
NOEXPORT=true
BUG=688854
==========
to
==========
Import wpt@97e16bef6d6599ae805521e2007a9430a12aa144
Using wpt-import in Chromium 92dc22973ed15b4e4683d4ac73ea329763f65c25.
Manual import, with the following change:
Add Failure expectation for testharness test
"hr-time/window-worker-time-origin.html", and clean up TestExpectations.
NOEXPORT=true
BUG=688854
==========
3 years, 10 months ago
(2017-02-06 17:01:16 UTC)
#9
jsbell
lgtm Are we standardizing on [Timeout] for manual tests, rather than [Skip]? [Timeout] gives slightly ...
3 years, 10 months ago
(2017-02-06 17:37:31 UTC)
#10
lgtm
Are we standardizing on [Timeout] for manual tests, rather than [Skip]?
[Timeout] gives slightly better coverage, and if the test gets automated we'll
notice immediately. But it slows down test runs for everyone.
I'm fine either way but we should discuss/document. Or maybe that already
happened. :)
qyearsley
On 2017/02/06 at 17:37:31, jsbell wrote: > lgtm > > Are we standardizing on [Timeout] ...
3 years, 10 months ago
(2017-02-06 17:49:51 UTC)
#11
On 2017/02/06 at 17:37:31, jsbell wrote:
> lgtm
>
> Are we standardizing on [Timeout] for manual tests, rather than [Skip]?
[Timeout] gives slightly better coverage, and if the test gets automated we'll
notice immediately. But it slows down test runs for everyone.
>
> I'm fine either way but we should discuss/document. Or maybe that already
happened. :)
In a discussion from earlier, I think we (tkent, dpranke?) noted that importing
and giving failure expectations has the advantages:
- we're importing more so our copy of WPT more closely resembles the upstream
copy
- we have a bit more test coverage
- it's helpful when when Chromium bugs are fixed and the test results change
qyearsley
The CQ bit was unchecked by qyearsley@chromium.org
3 years, 10 months ago
(2017-02-06 17:50:00 UTC)
#12
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486403402046510, "parent_rev": "86db644cb3312b8de9ada51111d169d0a7b976ba", "commit_rev": "4f0d45e556a4fcbcb7e54b6ba9d14157a8cefc16"}
3 years, 10 months ago
(2017-02-06 18:09:55 UTC)
#15
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486403402046510,
"parent_rev": "86db644cb3312b8de9ada51111d169d0a7b976ba", "commit_rev":
"4f0d45e556a4fcbcb7e54b6ba9d14157a8cefc16"}
commit-bot: I haz the power
Description was changed from ========== Import wpt@97e16bef6d6599ae805521e2007a9430a12aa144 Using wpt-import in Chromium 92dc22973ed15b4e4683d4ac73ea329763f65c25. Manual import, with ...
3 years, 10 months ago
(2017-02-06 18:10:30 UTC)
#16
Message was sent while issue was closed.
Description was changed from
==========
Import wpt@97e16bef6d6599ae805521e2007a9430a12aa144
Using wpt-import in Chromium 92dc22973ed15b4e4683d4ac73ea329763f65c25.
Manual import, with the following change:
Add Failure expectation for testharness test
"hr-time/window-worker-time-origin.html", and clean up TestExpectations.
NOEXPORT=true
BUG=688854
==========
to
==========
Import wpt@97e16bef6d6599ae805521e2007a9430a12aa144
Using wpt-import in Chromium 92dc22973ed15b4e4683d4ac73ea329763f65c25.
Manual import, with the following change:
Add Failure expectation for testharness test
"hr-time/window-worker-time-origin.html", and clean up TestExpectations.
NOEXPORT=true
BUG=688854
Review-Url: https://codereview.chromium.org/2675133002
Cr-Commit-Position: refs/heads/master@{#448305}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f0d45e556a4fcbcb7e54b6ba9d1...
==========
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/4f0d45e556a4fcbcb7e54b6ba9d14157a8cefc16
3 years, 10 months ago
(2017-02-06 18:10:31 UTC)
#17
Issue 2675133002: Import wpt@97e16bef6d6599ae805521e2007a9430a12aa144
(Closed)
Created 3 years, 10 months ago by qyearsley
Modified 3 years, 10 months ago
Reviewers: jsbell, jeffcarp
Base URL:
Comments: 0