Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 2674973006: Move parsing of referrer policy header values to SecurityPolicy (Closed)

Created:
3 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 10 months ago
Reviewers:
dglazkov, estark
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, gavinp+prerender_chromium.org, kinuko+watch, loading-reviews+parser_chromium.org, rwlbuis, sof, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move parsing of referrer policy header values to SecurityPolicy Also unify the code paths for legacy and non-legacy policies a bit R=estark@chromium.org BUG=676645 Review-Url: https://codereview.chromium.org/2674973006 Cr-Commit-Position: refs/heads/master@{#448176} Committed: https://chromium.googlesource.com/chromium/src/+/4f43f2eacab108429daea2bf64678922fc85491e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -80 lines) Patch
M third_party/WebKit/Source/core/dom/ExecutionContext.cpp View 1 chunk +6 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLIFrameElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLLinkElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SecurityPolicy.h View 2 chunks +10 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp View 3 chunks +54 lines, -49 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jochen (gone - plz use gerrit)
3 years, 10 months ago (2017-02-05 03:14:53 UTC) #1
dglazkov
lgtm
3 years, 10 months ago (2017-02-05 03:48:45 UTC) #5
jochen (gone - plz use gerrit)
<meme img=allowit>i'll take it</meme>
3 years, 10 months ago (2017-02-05 03:50:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674973006/1
3 years, 10 months ago (2017-02-05 03:50:26 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-05 05:04:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f43f2eacab108429daea2bf6467...

Powered by Google App Engine
This is Rietveld 408576698