Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2674933002: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. (Closed)

Created:
3 years, 10 months ago by zakerinasab
Modified:
3 years, 10 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. This change replaces js-test.js assertions with testharness.js assertions. The expectation files are removed as they are not needed anymore. To simplify review and landing, each change corrects 10 tests. BUG=639732 Review-Url: https://codereview.chromium.org/2674933002 Cr-Commit-Position: refs/heads/master@{#448636} Committed: https://chromium.googlesource.com/chromium/src/+/418400229957dc4f45021047cd1fcdb751ed9590

Patch Set 1 #

Total comments: 6

Patch Set 2 : Corrections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -486 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/canvas-frameless-document-text.html View 1 1 chunk +26 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-frameless-document-text-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-getContext-invalid.html View 1 1 chunk +18 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-getContext-invalid-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData.html View 1 2 chunks +47 lines, -69 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-expected.txt View 1 chunk +0 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-invalid.html View 1 1 chunk +22 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-invalid-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-large-crash.html View 1 chunk +6 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-large-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-largeNonintegralDimensions.html View 1 chunk +8 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-largeNonintegralDimensions-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-negative-source.html View 1 1 chunk +33 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-negative-source-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-p3.html View 1 1 chunk +28 lines, -29 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-rec-2020.html View 1 1 chunk +28 lines, -29 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-rounding.html View 1 1 chunk +33 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-getImageData-rounding-expected.txt View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/canvas-gradient-without-path.html View 1 chunk +36 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-gradient-without-path-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-frameless-document-text.js View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-getContext-invalid.js View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-getImageData-invalid.js View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-getImageData-negative-source.js View 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-gradient-without-path.js View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
zakerinasab
CL uploaded. PTAL.
3 years, 10 months ago (2017-02-03 17:51:01 UTC) #3
Justin Novosad
lgtm with nits https://codereview.chromium.org/2674933002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-frameless-document-text.html File third_party/WebKit/LayoutTests/fast/canvas/canvas-frameless-document-text.html (right): https://codereview.chromium.org/2674933002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/canvas-frameless-document-text.html#newcode7 third_party/WebKit/LayoutTests/fast/canvas/canvas-frameless-document-text.html:7: // It is not clear from ...
3 years, 10 months ago (2017-02-03 18:07:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674933002/20001
3 years, 10 months ago (2017-02-07 15:43:16 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 16:06:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/418400229957dc4f45021047cd1f...

Powered by Google App Engine
This is Rietveld 408576698