Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2674903003: Revert of Dont post delayed DoWork for disabled queues. (Closed)

Created:
3 years, 10 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 10 months ago
Reviewers:
haraken, Sami
CC:
chromium-reviews, blink-reviews, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Dont post delayed DoWork for disabled queues. (patchset #9 id:160001 of https://codereview.chromium.org/2572893002/ ) Reason for revert: Speculative revert. Might be causing renderer hangs. Original issue's description: > Dont post delayed DoWork for disabled queues. We could do this for fences too but don't > because that would break the throttling logic which needs to know when the next delayed > task is due to be run. > > BUG=671669 > > Committed: https://crrev.com/cab9842ac55e5b9dab766f11c6e412949d854483 > Cr-Original-Commit-Position: refs/heads/master@{#438962} > Review-Url: https://codereview.chromium.org/2572893002 > Cr-Commit-Position: refs/heads/master@{#447591} > Committed: https://chromium.googlesource.com/chromium/src/+/9a8a61516e750796f74869167bb919a05551d4dd TBR=skyostil@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=671669, 688426, 688422 Review-Url: https://codereview.chromium.org/2674903003 Cr-Commit-Position: refs/heads/master@{#448046} Committed: https://chromium.googlesource.com/chromium/src/+/205b4a6222828e70127989c9451bbbd5e56be02d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -391 lines) Patch
M third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/real_time_domain.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc View 4 chunks +7 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h View 5 chunks +6 lines, -61 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc View 10 chunks +34 lines, -55 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_perftest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc View 17 chunks +45 lines, -119 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain.h View 2 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain.cc View 3 chunks +5 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc View 8 chunks +41 lines, -68 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
alex clarke (OOO till 29th)
Created Revert of Dont post delayed DoWork for disabled queues.
3 years, 10 months ago (2017-02-03 17:51:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674903003/1
3 years, 10 months ago (2017-02-03 17:52:02 UTC) #3
haraken
LGTM
3 years, 10 months ago (2017-02-03 18:12:42 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 19:30:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/205b4a6222828e70127989c9451b...

Powered by Google App Engine
This is Rietveld 408576698