Change SK_GAMMA_CONTRAST in Windows from 0.5 to 1.0.

Change SK_GAMMA_CONTRAST in Windows from 0.5 to 1.0.

Firefox applies an enhancedContrast of 1.0 instead of the documented 0.5
See
https://hg.mozilla.org/mozilla-central/file/tip/gfx/thebes/gfxWindowsPlatform.cpp#l1224
for the actual value and
https://hg.mozilla.org/mozilla-central/file/tip/modules/libpref/init/all.js#l3436
for the documented value.

This CL changes SK_GAMMA_CONTRAST (windows) from 0.5 to 1.0 to follow
the actual behavior of Firefox. Screenshots can be found in bug 534732.

BUG=534732, 630917

[WC Leung, 2017-02-03 12:58:42]

Description was changed from

==========
Change SK_GAMMA_CONTRAST from 0.5 to 1.0.

Firefox applied an enhancedContrast of 1.0 instead of the documented 0.5
See
https://hg.mozilla.org/mozilla-central/file/tip/gfx/thebes/gfxWindowsPlatform...
for the actual value and
https://hg.mozilla.org/mozilla-central/file/tip/modules/libpref/init/all.js#l...
for the documented value.

This CL changes SK_GAMMA_CONTRAST from 0.5 to 1.0 to follow the actual
behavior of Firefox. Screenshots can be found in bug 534732.

BUG=534732, 630917
==========

to

==========
Change SK_GAMMA_CONTRAST from 0.5 to 1.0.

Firefox applied an enhancedContrast of 1.0 instead of the documented 0.5
See
https://hg.mozilla.org/mozilla-central/file/tip/gfx/thebes/gfxWindowsPlatform...
for the actual value and
https://hg.mozilla.org/mozilla-central/file/tip/modules/libpref/init/all.js#l...
for the documented value.

This CL changes SK_GAMMA_CONTRAST from 0.5 to 1.0 to follow the actual
behavior of Firefox. Screenshots can be found in bug 534732.

BUG=534732, 630917
==========

[WC Leung, 2017-02-03 12:58:42]

lwchkg@chromium.org changed reviewers:
+ bungeman@google.com

[WC Leung, 2017-02-03 13:04:33]

Description was changed from

==========
Change SK_GAMMA_CONTRAST from 0.5 to 1.0.

Firefox applied an enhancedContrast of 1.0 instead of the documented 0.5
See
https://hg.mozilla.org/mozilla-central/file/tip/gfx/thebes/gfxWindowsPlatform...
for the actual value and
https://hg.mozilla.org/mozilla-central/file/tip/modules/libpref/init/all.js#l...
for the documented value.

This CL changes SK_GAMMA_CONTRAST from 0.5 to 1.0 to follow the actual
behavior of Firefox. Screenshots can be found in bug 534732.

BUG=534732, 630917
==========

to

==========
Change SK_GAMMA_CONTRAST in Windows from 0.5 to 1.0.

Firefox applied an enhancedContrast of 1.0 instead of the documented 0.5
See
https://hg.mozilla.org/mozilla-central/file/tip/gfx/thebes/gfxWindowsPlatform...
for the actual value and
https://hg.mozilla.org/mozilla-central/file/tip/modules/libpref/init/all.js#l...
for the documented value.

This CL changes SK_GAMMA_CONTRAST from 0.5 to 1.0 to follow the actual
behavior of Firefox. Screenshots can be found in bug 534732.

BUG=534732, 630917
==========

[WC Leung, 2017-02-03 13:04:47]

Description was changed from

==========
Change SK_GAMMA_CONTRAST in Windows from 0.5 to 1.0.

Firefox applied an enhancedContrast of 1.0 instead of the documented 0.5
See
https://hg.mozilla.org/mozilla-central/file/tip/gfx/thebes/gfxWindowsPlatform...
for the actual value and
https://hg.mozilla.org/mozilla-central/file/tip/modules/libpref/init/all.js#l...
for the documented value.

This CL changes SK_GAMMA_CONTRAST from 0.5 to 1.0 to follow the actual
behavior of Firefox. Screenshots can be found in bug 534732.

BUG=534732, 630917
==========

to

==========
Change SK_GAMMA_CONTRAST in Windows from 0.5 to 1.0.

Firefox applies an enhancedContrast of 1.0 instead of the documented 0.5
See
https://hg.mozilla.org/mozilla-central/file/tip/gfx/thebes/gfxWindowsPlatform...
for the actual value and
https://hg.mozilla.org/mozilla-central/file/tip/modules/libpref/init/all.js#l...
for the documented value.

This CL changes SK_GAMMA_CONTRAST from 0.5 to 1.0 to follow the actual
behavior of Firefox. Screenshots can be found in bug 534732.

BUG=534732, 630917
==========

[WC Leung, 2017-02-03 13:05:15]

Description was changed from

==========
Change SK_GAMMA_CONTRAST in Windows from 0.5 to 1.0.

Firefox applies an enhancedContrast of 1.0 instead of the documented 0.5
See
https://hg.mozilla.org/mozilla-central/file/tip/gfx/thebes/gfxWindowsPlatform...
for the actual value and
https://hg.mozilla.org/mozilla-central/file/tip/modules/libpref/init/all.js#l...
for the documented value.

This CL changes SK_GAMMA_CONTRAST from 0.5 to 1.0 to follow the actual
behavior of Firefox. Screenshots can be found in bug 534732.

BUG=534732, 630917
==========

to

==========
Change SK_GAMMA_CONTRAST in Windows from 0.5 to 1.0.

Firefox applies an enhancedContrast of 1.0 instead of the documented 0.5
See
https://hg.mozilla.org/mozilla-central/file/tip/gfx/thebes/gfxWindowsPlatform...
for the actual value and
https://hg.mozilla.org/mozilla-central/file/tip/modules/libpref/init/all.js#l...
for the documented value.

This CL changes SK_GAMMA_CONTRAST (windows) from 0.5 to 1.0 to follow
the actual behavior of Firefox. Screenshots can be found in bug 534732.

BUG=534732, 630917
==========

[WC Leung, 2017-02-03 13:06:27]

bungeman@: PTAL.

kojii@ and others. FYI. I've checked that this fixes bug 630917, and you may
want to test it too.

Regards,
WC Leung.

[WC Leung, 2017-02-03 13:13:48]

The CQ bit was checked by lwchkg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 13:14:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 14:30:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 14:30:03]

Dry run: This issue passed the CQ dry run.

[bungeman-chromium, 2017-02-03 14:56:24]

bungeman@chromium.org changed reviewers:
+ bungeman@chromium.org

[bungeman-chromium, 2017-02-03 14:56:24]

This does not lgtm. Your example in Firefox does not apply because
SK_GAMMA_CONTRAST is not a thing which is passed to DirectWrite,
SK_GAMMA_CONTRAST actually controls something else in our mask blitting.

[WC Leung, 2017-02-03 14:58:06]

On 2017/02/03 14:56:24, bungeman-chromium wrote:
> This does not lgtm. Your example in Firefox does not apply because
> SK_GAMMA_CONTRAST is not a thing which is passed to DirectWrite,
> SK_GAMMA_CONTRAST actually controls something else in our mask blitting.

Thanks. I'll try again.