Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 2674823002: flatc now become deterministic. (Closed)

Created:
3 years, 10 months ago by Yoshisato Yanagisawa
Modified:
3 years, 10 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

flatc now become deterministic. Since __DATE__, __TIME__, and __TIMESTAMP__ has been set during the build, flatc now become deterministic. BUG=314403 Review-Url: https://codereview.chromium.org/2674823002 Cr-Commit-Position: refs/heads/master@{#448033} Committed: https://chromium.googlesource.com/chromium/src/+/9f222f933687afae647f761c9c274d6a2d2a20fc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/determinism/deterministic_build_whitelist.pyl View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yoshisato Yanagisawa
3 years, 10 months ago (2017-02-03 05:12:02 UTC) #2
M-A Ruel
yay! lgtm
3 years, 10 months ago (2017-02-03 16:21:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674823002/1
3 years, 10 months ago (2017-02-03 16:22:10 UTC) #5
Dirk Pranke
lgtm
3 years, 10 months ago (2017-02-03 16:43:40 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 19:11:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9f222f933687afae647f761c9c27...

Powered by Google App Engine
This is Rietveld 408576698