Use allSinks to find a sink in kFindSinkScript.

chrome/test/media_router/media_router_integration_browsertest.cc

Index: chrome/test/media_router/media_router_integration_browsertest.cc
diff --git a/chrome/test/media_router/media_router_integration_browsertest.cc b/chrome/test/media_router/media_router_integration_browsertest.cc
index 32a5e7de342edaa59860ce9dde37854c184687d2..a499e07b9513c1c1c506b7b4d44f3c6c8a77f39c 100644
--- a/chrome/test/media_router/media_router_integration_browsertest.cc
+++ b/chrome/test/media_router/media_router_integration_browsertest.cc
@@ -83,10 +83,9 @@ const char kGetRouteIdScript[] =
     "}"
     "domAutomationController.send('');";
 const char kFindSinkScript[] =
-    "var sinks = document.getElementById('media-router-container')."
-    "  shadowRoot.getElementById('sink-list').getElementsByTagName('span');"
+    "var sinks = document.getElementById('media-router-container').allSinks;"

[imcheng, 2017/02/06 21:36:03]

I don't think we should be using allSinks, as it is not user-visible and not all
sinks in allSinks show up in the sink list. Also it seems the test will just
fail later, rather than here, when we try to choose thesink in the test.

It looks like the test failure is caused by sink-list not created yet. Can we
modify this script to check for non-null before proceeding?

[cliffordcheng1, 2017/02/06 23:11:26]

The other option is to check if the sink-list is null or not before proceeding.
If it is null, it will just send false.
WaitUntilSinkDiscoveredOnUI() will wait 30s before timeout.
Does that sound better?

     "for (var i=0; i<sinks.length; i++) {"
-    "  if (sinks[i].textContent.trim() == '%s') {"
+    "  if (sinks[i].name.trim() == '%s') {"
     "    domAutomationController.send(true);"
     "}}"
     "domAutomationController.send(false);";