Use allSinks to find a sink in kFindSinkScript.

chrome/test/media_router/media_router_integration_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/media_router/media_router_integration_browsertest.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
@@ skipping 65 matching lines @@
 const char kGetRouteIdScript[] =
     "var routes = window.document.getElementById('media-router-container')."
     "  routeList;"
     "for (var i=0; i<routes.length; i++) {"
     "  if (routes[i].sinkId == '%s') {"
     "    domAutomationController.send(routes[i].id);"
     "  }"
     "}"
     "domAutomationController.send('');";
 const char kFindSinkScript[] =
-    "var sinks = document.getElementById('media-router-container')."
-    "  shadowRoot.getElementById('sink-list').getElementsByTagName('span');"
+    "var sinks = document.getElementById('media-router-container').allSinks;"

[imcheng, 2017/02/06 21:36:03]

I don't think we should be using allSinks, as it is not user-visible and not all
sinks in allSinks show up in the sink list. Also it seems the test will just
fail later, rather than here, when we try to choose thesink in the test.

It looks like the test failure is caused by sink-list not created yet. Can we
modify this script to check for non-null before proceeding?

[cliffordcheng1, 2017/02/06 23:11:26]

The other option is to check if the sink-list is null or not before proceeding.
If it is null, it will just send false.
WaitUntilSinkDiscoveredOnUI() will wait 30s before timeout.
Does that sound better?

     "for (var i=0; i<sinks.length; i++) {"
-    "  if (sinks[i].textContent.trim() == '%s') {"
+    "  if (sinks[i].name.trim() == '%s') {"
     "    domAutomationController.send(true);"
     "}}"
     "domAutomationController.send(false);";
 const char kCheckDialogLoadedScript[] =
     "var container = document.getElementById('media-router-container');"
     "/** Wait until media router container is not undefined and "
     "*   deviceMissingUrl is not undefined, "
     "*   once deviceMissingUrl is not undefined, which means "
     "*   the dialog is fully loaded."
     "*/"
@@ skipping 529 matching lines @@
 
   MediaRouterDialogControllerImpl* controller =
       MediaRouterDialogControllerImpl::GetOrCreateForWebContents(web_contents);
   EXPECT_TRUE(controller->IsShowingMediaRouterDialog());
   WaitUntilSinkDiscoveredOnUI();
   controller->HideMediaRouterDialog();
   CheckStartFailed(web_contents, "NotFoundError", "No screens found.");
 }
 
 }  // namespace media_router