Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2674793003: Media Session: move all tests but mojo/ ones to external/wpt/. (Closed)

Created:
3 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media Session: move all tests but mojo/ ones to external/wpt/. A couple of tests have been merged and/or moved to idlharness.html BUG=688222 R=foolip@chromium.org Review-Url: https://codereview.chromium.org/2674793003 Cr-Commit-Position: refs/heads/master@{#448998} Committed: https://chromium.googlesource.com/chromium/src/+/dabe5bbe5e95b95511c75f79dcd1817286ce6f07

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+397 lines, -272 lines) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json View 1 4 chunks +59 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediasession/README.md View 1 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediasession/idlharness.html View 1 chunk +89 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediasession/idlharness-expected.txt View 1 chunk +31 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/mediasession/mediametadata.html View 1 chunk +192 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/mediasession/playbackstate.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/mediasession/setactionhandler.html View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/mediasession/mediasession.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/mediasession/mediasession-playbackstate.html View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/mediasession/mediasession-playbackstate-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/mediasession/mediasession-setactionhandler.html View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html View 1 chunk +0 lines, -172 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/mediasession/navigator-mediasession.html View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
mlamouri (slow - plz ping)
3 years, 10 months ago (2017-02-03 02:35:30 UTC) #3
mlamouri (slow - plz ping)
+zqzhang@
3 years, 10 months ago (2017-02-03 02:48:33 UTC) #5
tkent
I recommend to add wpt/mediasession/README.md. Also, you should add ##Owners entry to LayoutTests/W3CImportExpectations. Otherwise, we ...
3 years, 10 months ago (2017-02-03 02:58:30 UTC) #6
foolip
lgtm % W3CImportExpectations fix. What will happen without an added entry is that all of ...
3 years, 10 months ago (2017-02-05 23:26:16 UTC) #9
Zhiqiang Zhang (Slow)
Tests lgtm % nit https://codereview.chromium.org/2674793003/diff/1/third_party/WebKit/LayoutTests/media/mediasession/navigator-mediasession.html File third_party/WebKit/LayoutTests/media/mediasession/navigator-mediasession.html (left): https://codereview.chromium.org/2674793003/diff/1/third_party/WebKit/LayoutTests/media/mediasession/navigator-mediasession.html#oldcode7 third_party/WebKit/LayoutTests/media/mediasession/navigator-mediasession.html:7: test(function() { nit: Is this ...
3 years, 10 months ago (2017-02-06 11:14:23 UTC) #10
mlamouri (slow - plz ping)
https://codereview.chromium.org/2674793003/diff/1/third_party/WebKit/LayoutTests/media/mediasession/navigator-mediasession.html File third_party/WebKit/LayoutTests/media/mediasession/navigator-mediasession.html (left): https://codereview.chromium.org/2674793003/diff/1/third_party/WebKit/LayoutTests/media/mediasession/navigator-mediasession.html#oldcode7 third_party/WebKit/LayoutTests/media/mediasession/navigator-mediasession.html:7: test(function() { On 2017/02/06 at 11:14:23, Zhiqiang Zhang wrote: ...
3 years, 10 months ago (2017-02-08 13:39:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674793003/20001
3 years, 10 months ago (2017-02-08 14:02:19 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 15:14:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dabe5bbe5e95b95511c75f79dcd1...

Powered by Google App Engine
This is Rietveld 408576698