Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 2674703002: [Sensors] Stop throwing InvalidStateError exceptions (Closed)

Created:
3 years, 10 months ago by Mikhail
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews, wanming.lin, shalamov, Mikhail, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] Stop throwing InvalidStateError exceptions The updated Generic Sensor specification [1] does not contain instructions for throwing 'InvalidStateError' exceptions from start() and stop() methods. This allows for example to call stop() method on already stopped sensor object (such call will be simply ignored). BUG=606766 [1] https://w3c.github.io/sensors/ Review-Url: https://codereview.chromium.org/2674703002 Cr-Commit-Position: refs/heads/master@{#447802} Committed: https://chromium.googlesource.com/chromium/src/+/f5e04ad29b1ef9e8bf180191ef57120163faa0a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mikhail
PTAL
3 years, 10 months ago (2017-02-02 14:27:06 UTC) #5
haraken
LGTM
3 years, 10 months ago (2017-02-02 15:17:52 UTC) #6
Reilly Grant (use Gerrit)
lgtm
3 years, 10 months ago (2017-02-02 17:35:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674703002/1
3 years, 10 months ago (2017-02-02 18:31:50 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 18:37:30 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5e04ad29b1ef9e8bf180191ef57...

Powered by Google App Engine
This is Rietveld 408576698