Add nacl sdk builders to default try list.

Add nacl sdk builders to default try list.

These are the new "build-only" builders for that
NaCl SDK which should be fast and reliable and
catch basic build breaks.

BUG=302579
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244280

[Sam Clegg, 2013-11-25 19:29:54]

Still waiting on a tryserver restart to pull in this change:
https://codereview.chromium.org/80003002/.

[ghost stip (do not use), 2013-12-02 20:07:21]

just so you're aware, this doesn't affect CQ as CQ reads from it's projects.py.
I'm in the middle of unifying CQ and PRESUBMIT.py, which will make that
distinction go away.

[Sam Clegg, 2013-12-11 21:18:19]

On 2013/12/02 20:07:21, stip wrote:
> just so you're aware, this doesn't affect CQ as CQ reads from it's
projects.py.
> I'm in the middle of unifying CQ and PRESUBMIT.py, which will make that
> distinction go away.

This should be ready to go now.  PTAL.

[Sam Clegg, 2013-12-27 22:01:41]

friendly ping.

[ghost stip (do not use), 2014-01-07 00:36:18]

lgtm

[commit-bot: I haz the power, 2014-01-07 18:46:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/26747002/112001

[commit-bot: I haz the power, 2014-01-07 18:46:29]

Failed to apply patch for PRESUBMIT.py:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file PRESUBMIT.py
  Hunk #1 succeeded at 1274 with fuzz 2 (offset 3 lines).
  Hunk #2 FAILED at 1283.
  Hunk #3 succeeded at 1301 (offset 5 lines).
  Hunk #4 succeeded at 1409 (offset 5 lines).
  1 out of 4 hunks FAILED -- saving rejects to file PRESUBMIT.py.rej

Patch:       PRESUBMIT.py
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index
5e64d57ed460d8138391209fd5f2161007609034..b63fc55e58b95178d4659df6bfcca170766d3110
100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -1271,6 +1271,7 @@ def GetDefaultTryConfigs(bots=None):
           'sandbox_linux_unittests',
       ],
       'linux_clang': ['compile'],
+      'linux_nacl_sdk_build': ['compile'],
       'linux_rel': standard_tests + [
           'cc_unittests',
           'chromedriver_unittests',
@@ -1282,6 +1283,7 @@ def GetDefaultTryConfigs(bots=None):
           'sync_integration_tests',
       ],
       'mac': ['compile'],
+      'mac_nacl_sdk_build': ['compile'],
       'mac_rel': standard_tests + [
           'app_list_unittests',
           'cc_unittests',
@@ -1295,6 +1297,7 @@ def GetDefaultTryConfigs(bots=None):
           'telemetry_unittests',
       ],
       'win': ['compile'],
+      'win_nacl_sdk_build': ['compile'],
       'win_rel': standard_tests + [
           'app_list_unittests',
           'ash_unittests',
@@ -1402,10 +1405,13 @@ def GetPreferredTrySlaves(project, change):
       'linux_asan',
       'linux_chromeos',
       'linux_clang',
+      'linux_nacl_sdk_build',
       'linux_rel',
       'mac',
+      'mac_nacl_sdk_build',
       'mac_rel',
       'win',
+      'win_nacl_sdk_build',
       'win_rel',
       'win_x64_rel',
   ])

[commit-bot: I haz the power, 2014-01-09 22:16:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/26747002/412001

[commit-bot: I haz the power, 2014-01-09 22:54:48]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Sam Clegg, 2014-01-10 17:12:21]

+maruel for PRESUBMIT.py OWNERS

[M-A Ruel, 2014-01-10 17:15:17]

rubberstamp lgtm, note that 'compile' does force the builder to unconditionally
build everything, independent of which target it usually builds.

[Sam Clegg, 2014-01-10 17:28:00]

On 2014/01/10 17:15:17, M-A Ruel wrote:
> rubberstamp lgtm, note that 'compile' does force the builder to
unconditionally
> build everything, independent of which target it usually builds.

These builders don't actually do any building of chrome targets.  They just
build the nacl_sdk from the chrome tree.

[commit-bot: I haz the power, 2014-01-10 18:20:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/26747002/412001

[commit-bot: I haz the power, 2014-01-10 22:53:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sbc@chromium.org/26747002/412001

[commit-bot: I haz the power, 2014-01-11 00:12:05]

Change committed as 244280

[Nico, 2014-01-22 21:20:14]

I've never seen a run of linux_nacl_sdk_build that didn't fail in "SDK Items".
Can this bot be removed from the `git cl try` default set again?

(Random example failure:
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk_build/...

Last 200 builds are all red:
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk_build?...
)

[sbc, 2014-01-22 22:09:34]

Sorry about the redness here.  This bot is in the default try set as a
step towards getting it into the CQ.

It was green for a long time until a recent NaCl roll broke it:
https://codereview.chromium.org/135713005.  If you look at try runs
prior to this they were green:
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk_build/...
By adding this bot the CQ we can stop future changes like this from
breaking the SDK build.

I've got a CL which should make it green again (when combined with the
next NaCl Roll): https://codereview.chromium.org/132523006/.

Updating the trybot image would also make them green again as it would
add the ARM cross compiler
(https://code.google.com/p/chromium/issues/detail?id=335303).

cheers,
sam

On Wed, Jan 22, 2014 at 1:20 PM,  <thakis@chromium.org> wrote:
> I've never seen a run of linux_nacl_sdk_build that didn't fail in "SDK
> Items".
> Can this bot be removed from the `git cl try` default set again?
>
> (Random example failure:
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk_build/...
>
> Last 200 builds are all red:
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk_build?...
> )
>
> https://codereview.chromium.org/26747002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-01-22 22:11:30]

Can it be disabled until either of these changes has landed?

Do you have an FYI bot for this?

During bringup for a new bot, I usually have an FYI instance that emails me
every time it goes red, so that I can fix issues like this immediately (or,
if necessary, temporarily turn of my developer-visible bot).


On Wed, Jan 22, 2014 at 2:09 PM, Sam Clegg <sbc@google.com> wrote:

> Sorry about the redness here.  This bot is in the default try set as a
> step towards getting it into the CQ.
>
> It was green for a long time until a recent NaCl roll broke it:
> https://codereview.chromium.org/135713005.  If you look at try runs
> prior to this they were green:
>
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk_build/...
> By adding this bot the CQ we can stop future changes like this from
> breaking the SDK build.
>
> I've got a CL which should make it green again (when combined with the
> next NaCl Roll): https://codereview.chromium.org/132523006/.
>
> Updating the trybot image would also make them green again as it would
> add the ARM cross compiler
> (https://code.google.com/p/chromium/issues/detail?id=335303).
>
> cheers,
> sam
>
> On Wed, Jan 22, 2014 at 1:20 PM,  <thakis@chromium.org> wrote:
> > I've never seen a run of linux_nacl_sdk_build that didn't fail in "SDK
> > Items".
> > Can this bot be removed from the `git cl try` default set again?
> >
> > (Random example failure:
> >
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk_build/...
> >
> > Last 200 builds are all red:
> >
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk_build?...
> > )
> >
> > https://codereview.chromium.org/26747002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sbc, 2014-01-22 22:18:16]

Sure, I can temporarily remove these bots from the default try set.

We have a set of client bots that do superset of what these new trybots do:
http://build.chromium.org/p/client.nacl.sdk/waterfall



On Wed, Jan 22, 2014 at 2:11 PM, Nico Weber <thakis@chromium.org> wrote:
> Can it be disabled until either of these changes has landed?
>
> Do you have an FYI bot for this?
>
> During bringup for a new bot, I usually have an FYI instance that emails me
> every time it goes red, so that I can fix issues like this immediately (or,
> if necessary, temporarily turn of my developer-visible bot).
>
>
> On Wed, Jan 22, 2014 at 2:09 PM, Sam Clegg <sbc@google.com> wrote:
>>
>> Sorry about the redness here.  This bot is in the default try set as a
>> step towards getting it into the CQ.
>>
>> It was green for a long time until a recent NaCl roll broke it:
>> https://codereview.chromium.org/135713005.  If you look at try runs
>> prior to this they were green:
>>
>>
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk_build/...
>> By adding this bot the CQ we can stop future changes like this from
>> breaking the SDK build.
>>
>> I've got a CL which should make it green again (when combined with the
>> next NaCl Roll): https://codereview.chromium.org/132523006/.
>>
>> Updating the trybot image would also make them green again as it would
>> add the ARM cross compiler
>> (https://code.google.com/p/chromium/issues/detail?id=335303).
>>
>> cheers,
>> sam
>>
>> On Wed, Jan 22, 2014 at 1:20 PM,  <thakis@chromium.org> wrote:
>> > I've never seen a run of linux_nacl_sdk_build that didn't fail in "SDK
>> > Items".
>> > Can this bot be removed from the `git cl try` default set again?
>> >
>> > (Random example failure:
>> >
>> >
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk_build/...
>> >
>> > Last 200 builds are all red:
>> >
>> >
http://build.chromium.org/p/tryserver.chromium/builders/linux_nacl_sdk_build?...
>> > )
>> >
>> > https://codereview.chromium.org/26747002/
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.