NaCl: Update revision in DEPS, r12586 -> r12611

NaCl: Update revision in DEPS, r12586 -> r12611

This pulls in the following Native Client changes:

r12587: (jvoung) Don't build the static compiler_rt library with fPIC.
r12588: (dschuff) PNaCl build: Do not rename LLVMgold plugin library after building
r12589: (sbc) Add gyp build of sel_ldr and irt_core for ARM.
r12590: (dschuff) LLVM Test suite: remove IndirectGoto test from known failure list.
r12591: (bradnelson) Pulling in newer toolchain version.
r12592: (bradnelson) Pulling in newer toolchain version.
r12593: (jfb) Update TOOL_REVISIONS for PNaCl r12579->r12590
r12594: (jfb) Update the PNaCl TOOL_REVISIONS updater.
r12595: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r12596: (jfb) Update the PNaCl TOOL_REVISIONS updater.
r12597: (jfb) Update TOOL_REVISIONS for PNaCl r12590->r12595
r12598: (jfb) PNaCl TOOL_REVISIONS: more descriptive change list, and include toolchain_build changes.
r12599: (jfb) PNaCl TOOL_REVISIONS: add the --svn-id option
r12600: (mseaborn) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS: fix use-after-free
r12601: (mseaborn) PNaCl: Add definitions of __nacl_tp_{tls,tdb}_offset to native support code
r12602: (mseaborn) Update TOOL_REVISIONS for PNaCl r12595->r12601: TLS layout functions change
r12603: (mseaborn) PNaCl: Remove use of the TLS layout intrinsics
r12604: (mseaborn) PNaCl: Optimise getting the thread pointer by using read.tp intrinsic
r12605: (mseaborn) PNaCl: Remove use of the "llvm.nacl.target.arch" intrinsic
r12606: (mseaborn) PNaCl: Apply a consistent optimisation level to the native support code
r12607: (jvoung) Remove buildbot_pnacl.bat (buildbot_pnacl_toolchain.py is the new entry point)
r12608: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r12609: (yyanagisawa) Add revision number in REV for --version.
r12610: (dyen) Added a standardized host environment to Scons environments
r12611: (kschimpf) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS

BUG=none
TEST=browser_tests and nacl_integration

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245032

[bradn, 2014-01-14 20:59:58]

lgtm

[commit-bot: I haz the power, 2014-01-14 23:23:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mseaborn@chromium.org/135713005/1

[commit-bot: I haz the power, 2014-01-15 02:48:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mseaborn@chromium.org/135713005/1

[commit-bot: I haz the power, 2014-01-16 00:23:34]

Change committed as 245032

[Sam Clegg, 2014-01-16 21:47:29]

Ooops, this broke the linux NaCl SDK bots.  I've got a chrome side fix for this
(https://codereview.chromium.org/126223002/)
but this requires all the linux bots to have the ARM cross toolchain installed
(since it now builds sel_ldr etc for ARM).

Can we revert this? (along with https://codereview.chromium.org/140653002)?

[Mark Seaborn, 2014-01-17 16:54:27]

On 16 January 2014 13:47, <sbc@chromium.org> wrote:

> Ooops, this broke the linux NaCl SDK bots.


Sorry about that.  My bandwidth for checking the trybot results for DEPS
rolls has shrunk, so I started committing them using the Commit Queue.
 Unfortunately that doesn't test the SDK build.

One problem is that the SDK build isn't a tree-closer and doesn't affect
LKGR, so if linux_nacl_sdk fails on a trybot run, I don't know if that's
because the DEPS roll broke it or because it was broken already (or is
flaky).  And I'm not familiar enough with the SDK build to be able to
determine the cause of a failure error quickly.

I could mitigate that by sending DEPS rolls to you to review instead of
Brad N.  How does that sound?

Longer term, can we make SDK build failures into tree-closers?


I've got a chrome side fix for this
> (https://codereview.chromium.org/126223002/)
> but this requires all the linux bots to have the ARM cross toolchain
> installed
> (since it now builds sel_ldr etc for ARM).
>
> Can we revert this? (along with https://codereview.chromium.org/140653002
> )?


Another nacl_revision update has gone in since this one...

Which was the NaCl-side change that broke this?  Is it "r12589: (sbc) Add
gyp build of sel_ldr and irt_core for ARM."?  Could we instead revert that
on the NaCl side and re-roll DEPS?

Cheers,
Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/groups/opt_out.

[Mark Seaborn, 2014-01-17 16:54:28]

On 16 January 2014 13:47, <sbc@chromium.org> wrote:

> Ooops, this broke the linux NaCl SDK bots.


Sorry about that.  My bandwidth for checking the trybot results for DEPS
rolls has shrunk, so I started committing them using the Commit Queue.
 Unfortunately that doesn't test the SDK build.

One problem is that the SDK build isn't a tree-closer and doesn't affect
LKGR, so if linux_nacl_sdk fails on a trybot run, I don't know if that's
because the DEPS roll broke it or because it was broken already (or is
flaky).  And I'm not familiar enough with the SDK build to be able to
determine the cause of a failure error quickly.

I could mitigate that by sending DEPS rolls to you to review instead of
Brad N.  How does that sound?

Longer term, can we make SDK build failures into tree-closers?


I've got a chrome side fix for this
> (https://codereview.chromium.org/126223002/)
> but this requires all the linux bots to have the ARM cross toolchain
> installed
> (since it now builds sel_ldr etc for ARM).
>
> Can we revert this? (along with https://codereview.chromium.org/140653002
> )?


Another nacl_revision update has gone in since this one...

Which was the NaCl-side change that broke this?  Is it "r12589: (sbc) Add
gyp build of sel_ldr and irt_core for ARM."?  Could we instead revert that
on the NaCl side and re-roll DEPS?

Cheers,
Mark

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sam Clegg, 2014-01-17 17:56:51]

On 2014/01/17 16:54:28, Mark Seaborn wrote:
> On 16 January 2014 13:47, <mailto:sbc@chromium.org> wrote:
> 
> > Ooops, this broke the linux NaCl SDK bots.
> 
> 
> Sorry about that.  My bandwidth for checking the trybot results for DEPS
> rolls has shrunk, so I started committing them using the Commit Queue.
>  Unfortunately that doesn't test the SDK build.
> 
> One problem is that the SDK build isn't a tree-closer and doesn't affect
> LKGR, so if linux_nacl_sdk fails on a trybot run, I don't know if that's
> because the DEPS roll broke it or because it was broken already (or is
> flaky).  And I'm not familiar enough with the SDK build to be able to
> determine the cause of a failure error quickly.
> 
> I could mitigate that by sending DEPS rolls to you to review instead of
> Brad N.  How does that sound?
> 
> Longer term, can we make SDK build failures into tree-closers?
> 


Yes, we are working on it.  The SDK bots are now in the default try list
which is step in the right direction.   The next step is to get them in
the CQ (which implies tree closer I think): 
https://code.google.com/p/chromium/issues/detail?id=302579

I'm afraid its really my fault as I made the breaking change
in the NaCl repo :(


> 
> I've got a chrome side fix for this
> > (https://codereview.chromium.org/126223002/)
> > but this requires all the linux bots to have the ARM cross toolchain
> > installed
> > (since it now builds sel_ldr etc for ARM).
> >
> > Can we revert this? (along with https://codereview.chromium.org/140653002
> > )?
> 
> 
> Another nacl_revision update has gone in since this one...
> 
> Which was the NaCl-side change that broke this?  Is it "r12589: (sbc) Add
> gyp build of sel_ldr and irt_core for ARM."?  Could we instead revert that
> on the NaCl side and re-roll DEPS?

Yes, exactly.

I've filed a ticket to get the arm linux cross compiler installed on
the trybot image but I don't know how long that will take to complete.

> 
> Cheers,
> Mark
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.